From: Stan Cox <scox@redhat.com>
To: Frysk List <frysk@sourceware.org>
Subject: elfutils import and debuginfo
Date: Tue, 18 Mar 2008 02:11:00 -0000 [thread overview]
Message-ID: <1205806284.13729.14.camel@multics.rdu.redhat.com> (raw)
This "patch" gets this test, which is testing frysk handling of external
debuginfo, to pass:
./TestRunner frysk.hpd.TestSysRoot
Running testHaveSysRoot(frysk.hpd.TestSysRoot) ...PASS
OK (1 test)
The test artificially creates a chroot by
creating /usr/bin, /usr/lib/debug, etc under a test directory and
populating that by using cp, debugedit and ed-strip. With elfutils
0.133 the test hits the case SHT_DYNSYM and ends up returning
DWFL_E_NOERROR. With elfutils 0.129 DWFL_E_NO_SYMTAB would be returned
resulting in find_debuginfo being called to find the debuginfo.
diff --git a/frysk-imports/elfutils/libdwfl/dwfl_module_getdwarf.c
b/frysk-imports/elfutils/libdwfl/dwfl_module_getdwarf.c
index 7dd9b53..ac13571 100644
--- a/frysk-imports/elfutils/libdwfl/dwfl_module_getdwarf.c
+++ b/frysk-imports/elfutils/libdwfl/dwfl_module_getdwarf.c
@@ -253,6 +253,7 @@ load_symtab (struct dwfl_file *file, struct
dwfl_file **symfile,
}
}
+#if 0
if (*symscn != NULL)
/* We found one, though no SHT_SYMTAB_SHNDX to go with it. */
return DWFL_E_NOERROR;
@@ -260,6 +261,7 @@ load_symtab (struct dwfl_file *file, struct
dwfl_file **symfile,
/* We found no SHT_SYMTAB, so any SHT_SYMTAB_SHNDX was bogus.
We might have found an SHT_DYNSYM and set *SYMSCN et al though.
*/
*xndxscn = NULL;
+#endif
return DWFL_E_NO_SYMTAB;
}
reply other threads:[~2008-03-18 2:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205806284.13729.14.camel@multics.rdu.redhat.com \
--to=scox@redhat.com \
--cc=frysk@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).