From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22492 invoked by alias); 18 Mar 2008 11:36:36 -0000 Received: (qmail 22480 invoked by uid 22791); 18 Mar 2008 11:36:35 -0000 X-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_40 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Mar 2008 11:36:18 +0000 Received: from dijkstra.wildebeest.org ([192.168.1.29]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1Jba74-0007Wg-OP; Tue, 18 Mar 2008 12:36:15 +0100 Subject: Re: [SCM] master: Extract TaskAttachedObserverXXX from TaskObserver, clarifying status. From: Mark Wielaard To: frysk@sourceware.org Cc: cagney@sourceware.org In-Reply-To: <20080317172731.3654.qmail@sourceware.org> References: <20080317172731.3654.qmail@sourceware.org> Content-Type: text/plain Date: Tue, 18 Mar 2008 11:36:00 -0000 Message-Id: <1205840174.3390.36.camel@dijkstra.wildebeest.org> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00157.txt.bz2 Hi Andrew, On Mon, 2008-03-17 at 17:27 +0000, cagney@sourceware.org wrote: > commit ec2bf1299f4d201f2452558aafd0880c680c729c > Author: Andrew Cagney > Date: Mon Mar 17 13:23:23 2008 -0400 > > Extract TaskAttachedObserverXXX from TaskObserver, clarifying status. > > frysk-core/frysk/bindir/ChangeLog > 2008-03-17 Andrew Cagney > > * fstep.java: Update; using TaskAttachedObserverXXX. > > frysk-core/frysk/ftrace/ChangeLog > 2008-03-17 Andrew Cagney > > * Ftrace.java: Update; using TaskAttachedObserverXXX. > > frysk-core/frysk/hpd/ChangeLog > 2008-03-17 Andrew Cagney > > * ShellCommand.java: Update; using TaskAttachedObserverXXX. > * StartRun.java: Ditto. > > frysk-core/frysk/proc/ChangeLog > 2008-03-17 Andrew Cagney > > * TaskObserver.java (Attached): Move to ... > * TaskAttachedObserverXXX.java: ... here. > * StressAttachDetachSignaledTask.java: Ditto. > * StressAttachDetachRapidlyCloningMainTask.java: Update. > * StressAttachDetachManyTasks.java: Update. > * TestTaskObserverInstruction.java: Update. > * TestTaskObserverInstructionSigReturn.java: Update. > * TestTaskSyscallObserver.java: Update. > * TestTaskObserver.java: Update. > * Host.java: Update. > * Task.java: Update. > * TestBreakpoints.java: Update. > * TestInstructions.java: Update. > * TestRun.java: Update. > > frysk-core/frysk/proc/dead/ChangeLog > 2008-03-17 Andrew Cagney > > * DeadHost.java: Update; using TaskAttachedObserverXXX; > * TestLinuxCore.java: Update. > * DeadTask.java: Ditto. > > frysk-core/frysk/proc/dummy/ChangeLog > 2008-03-17 Andrew Cagney > > * DummyHost.java: Update; using TaskAttachedObserverXXX. > * DummyTask.java: Ditto. > > frysk-core/frysk/proc/live/ChangeLog > 2008-03-17 Andrew Cagney > > * LinuxPtraceHost.java: Update; using TaskAttachedObserverXXX. > * TestTaskObserverCode.java: Ditto. > * TestTaskObserverBlocked.java: Ditto. > * TestRuntimeIsa.java: Ditto. > * LinuxWaitBuilder.java: Ditto. > * LinuxPtraceTask.java: Ditto. > > frysk-core/frysk/stepping/ChangeLog > 2008-03-17 Andrew Cagney > > * TestFirstInstruction.java: Update; using > TaskAttachedObserverXXX. > > frysk-core/frysk/testbed/ChangeLog > 2008-03-17 Andrew Cagney > > * OffspringType.java: Update; using TaskAttachedObserverXXX. > > frysk-core/frysk/util/ChangeLog > 2008-03-17 Andrew Cagney > > * ProcRunUtil.java: Update; using TaskAttachedObserverXXX. > > frysk-gui/frysk/gui/monitor/ChangeLog > 2008-03-17 Andrew Cagney > > * actions/RunExternal.java: Update; using TaskAttachedObserverXXX. > * MainWindow.java: Ditto. > > frysk-gui/frysk/gui/srcwin/ChangeLog > 2008-03-17 Andrew Cagney > > * SourceWindowFactory.java: Update; using TaskAttachedObserverXXX. What is your plan forward here? In the comments it says: > +++ b/frysk-core/frysk/proc/TaskAttachedObserverXXX.java > @@ -40,21 +40,20 @@ > package frysk.proc; > > /** > - * Interface to be used with Host.requestFindProc. > + * Interface used to notify of a Task that has has been attached, and > + * is about to resume execution in that state. Only after a Task has > + * been attached can its internals be manipulated (registers, memory, > + * auxv). > + * > + * XXX: This observer only works on un-attached tasks. > + * > + * XXX: This is an internal observer used to test the attached / > + * detached state transitions. It was never intended to escape into > + * the wild and is currently being re-captured. > */ All the cases you changed seemed to use it indeed as described. Indicate that they wanted to capture a specific process to be debugged/attached and then when it was start their processing. How do you see this being done in the future? Thanks, Mark