public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: frysk@sourceware.org
Cc: Andrew Cagney <cagney@sourceware.org>
Subject: Re: [SCM]  master: Always handle terminated events.
Date: Tue, 18 Mar 2008 12:17:00 -0000	[thread overview]
Message-ID: <1205842629.3390.45.camel@dijkstra.wildebeest.org> (raw)
In-Reply-To: <20080318024714.22518.qmail@sourceware.org>

Hi Andrew,

On Tue, 2008-03-18 at 02:47 +0000, cagney@sourceware.org wrote:
> commit dce689bb1f007f71609d223f8640332591297c8d
> Author: Andrew Cagney <cagney@redhat.com>
> Date:   Mon Mar 17 22:45:05 2008 -0400
> 
>     Always handle terminated events.
>     
>     frysk-core/frysk/proc/ChangeLog
>     2008-03-17  Andrew Cagney  <cagney@redhat.com>
>     
>     	* TestTaskObserver.java (attachDieingTask(int,boolean)): Do not
>     	check attached count.
>     
>     frysk-core/frysk/proc/live/ChangeLog
>     2008-03-17  Andrew Cagney  <cagney@redhat.com>
>     
>     	* LinuxPtraceTaskState.java (getDestroyed): Delete.
>     	(handleDisappearedEvent(LinuxPtraceTask)): Delete.
>     	(handleTerminatedEvent(LinuxPtraceTask,Signal,int)): Make
>     	abstract; implement in all sub-classes.
>     	* LinuxPtraceTask.java (processClonedEvent(LinuxPtraceTask)):
>     	Catch Errno.Esrch.
>     
>     frysk-sys/frysk/rsl/ChangeLog
>     2008-03-17  Andrew Cagney  <cagney@redhat.com>
>     
>     	* Log.java (log(String,Object,String,Object,String,int)): New.

This is an interesting hack to get around some of the nasty terminated
process corner cases. But a couple of questions.

Why don't you push the event on the queue? Currently you need to disable
some double state transition sanity checks because you are directly
calling handle event methods directly.

And what if one of the event handlers already processes an Errno itself
so you won't see it?

Cheers,

Mark

           reply	other threads:[~2008-03-18 12:17 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20080318024714.22518.qmail@sourceware.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205842629.3390.45.camel@dijkstra.wildebeest.org \
    --to=mark@klomp.org \
    --cc=cagney@sourceware.org \
    --cc=frysk@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).