public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: frysk <frysk@sourceware.org>
Subject: [patch] Make TestDebugInfoStackTrace.frameAssertions() more robust
Date: Wed, 19 Mar 2008 14:53:00 -0000	[thread overview]
Message-ID: <1205938395.3388.14.camel@dijkstra.wildebeest.org> (raw)

Hi,

While working on more unwind issues I noticed that
TestDebugInfoStackTrace.frameAssertions() didn't check for the actual
kill() and syscall() functions (only the internal library names). With
my new work the actual function names show up sometimes (not committed
yet), so these also need to be matched.

frysk-core/frysk/debuginfo/ChangeLog
2008-03-19  Mark Wielaard  <mwielaard@redhat.com>

    * TestDebugInfoStackTrace (frameAssertions): Also check for function
    names starting with kill or syscall.

Committed and pushed,

Mark


index 1939bb9..e932858 100644
--- a/frysk-core/frysk/debuginfo/TestDebugInfoStackTrace.java
+++ b/frysk-core/frysk/debuginfo/TestDebugInfoStackTrace.java
@@ -407,8 +407,8 @@ public class TestDebugInfoStackTrace
        String frameName =  this.frameTracker[i][index][2];
        
        while (frameName == null
-              || frameName.indexOf("kill") > 0
-              || frameName.indexOf("syscall") > 0)
+              || frameName.indexOf("kill") >= 0
+              || frameName.indexOf("syscall") >= 0)
          {
            index++;
            frameName = this.frameTracker[i][index][2];


                 reply	other threads:[~2008-03-19 14:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205938395.3388.14.camel@dijkstra.wildebeest.org \
    --to=mark@klomp.org \
    --cc=frysk@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).