From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20451 invoked by alias); 19 Mar 2008 14:53:37 -0000 Received: (qmail 20444 invoked by uid 22791); 19 Mar 2008 14:53:37 -0000 X-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 14:53:19 +0000 Received: from dijkstra.wildebeest.org ([192.168.1.29]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1JbzfI-0007xP-Bo for frysk@sourceware.org; Wed, 19 Mar 2008 15:53:16 +0100 Subject: [patch] Make TestDebugInfoStackTrace.frameAssertions() more robust From: Mark Wielaard To: frysk Content-Type: text/plain Date: Wed, 19 Mar 2008 14:53:00 -0000 Message-Id: <1205938395.3388.14.camel@dijkstra.wildebeest.org> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00169.txt.bz2 Hi, While working on more unwind issues I noticed that TestDebugInfoStackTrace.frameAssertions() didn't check for the actual kill() and syscall() functions (only the internal library names). With my new work the actual function names show up sometimes (not committed yet), so these also need to be matched. frysk-core/frysk/debuginfo/ChangeLog 2008-03-19 Mark Wielaard * TestDebugInfoStackTrace (frameAssertions): Also check for function names starting with kill or syscall. Committed and pushed, Mark index 1939bb9..e932858 100644 --- a/frysk-core/frysk/debuginfo/TestDebugInfoStackTrace.java +++ b/frysk-core/frysk/debuginfo/TestDebugInfoStackTrace.java @@ -407,8 +407,8 @@ public class TestDebugInfoStackTrace String frameName = this.frameTracker[i][index][2]; while (frameName == null - || frameName.indexOf("kill") > 0 - || frameName.indexOf("syscall") > 0) + || frameName.indexOf("kill") >= 0 + || frameName.indexOf("syscall") >= 0) { index++; frameName = this.frameTracker[i][index][2];