From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16969 invoked by alias); 2 Apr 2008 07:59:27 -0000 Received: (qmail 16959 invoked by uid 22791); 2 Apr 2008 07:59:26 -0000 X-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 02 Apr 2008 07:59:07 +0000 Received: from cc1341701-a.deven1.ov.home.nl ([82.72.53.253]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1Jgxrg-0008EE-7d; Wed, 02 Apr 2008 09:59:04 +0200 Subject: Re: [SCM] master: Merge branch 'master' of ssh://sources.redhat.com/git/frysk From: Mark Wielaard To: Phil Muldoon Cc: frysk@sourceware.org In-Reply-To: <47F242FD.4030001@redhat.com> References: <20080401122840.732.qmail@sourceware.org> <47F242FD.4030001@redhat.com> Content-Type: text/plain Date: Wed, 02 Apr 2008 07:59:00 -0000 Message-Id: <1207123115.4953.32.camel@cc1341701-a.deven1.ov.home.nl> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 7bit X-Spam-Score: -3.3 (---) X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q2/txt/msg00005.txt.bz2 Hi Phil, On Tue, 2008-04-01 at 15:13 +0100, Phil Muldoon wrote: > This commit build a dead simple watchpoint scenario. The assembly level > program writes to a global and exits. For the time being it is a sanity > tests for the upcoming Watchpoint observer code, and tests that > watchpoints at the lowest and most simple level work. Thanks for commenting on what you work on and why you introduced what. It really helps keeping an overview of what is happening with the code base and the various changes made in general. And also thanks for adding comments to this file in a later commit (my assembly is very rusty, so reading what it is actually supposed to do is very appreciated). Cheers, Mark P.S. The diffs on frysk-cvs look really strange at times. I always just post the actual patches myself since it seems the git diff on sourceware just scrambles them trying to be clever and associating random files with each other and generating a diff of them instead of a real diff of the original file :{