From: Mark Wielaard <mark@klomp.org>
To: frysk@sourceware.org
Subject: [patch] Make ferror use the right Option constructor
Date: Thu, 10 Apr 2008 11:38:00 -0000 [thread overview]
Message-ID: <1207824887.5343.44.camel@localhost.localdomain> (raw)
Hi,
The help text for ferror looked slightly strange:
ferror options:
-e error regex to catch in double quotes -e "<error string>" --error
Looking at the code revealed that it used the wrong Option constructor
(wrong order of arguments). This fixes it to use the Options(String,
char, String, String) constructor (long-option, short-option,
description, argument-description).
frysk-core/frysk/bindir/ChangeLog
2008-04-10 Mark Wielaard <mwielaard@redhat.com>
* ferror.java (options): Use correct Options constructor.
No regressions with this patch.
There is one failure that seems to have been there for a while (bug
#6390):
testFerrorTracesPID(frysk.bindir.TestFerror)junit.framework.AssertionFailedError: run until signal: assertSendAddCloneWaitForAcks(signals {SIGUSR1(10),SIGUSR2(12)}); outstanding: {SIGUSR2(12)}
Cheers,
Mark
diff --git a/frysk-core/frysk/bindir/ferror.java b/frysk-core/frysk/bindir/ferror.java
index 06cb1ca..ed0cbdb 100644
--- a/frysk-core/frysk/bindir/ferror.java
+++ b/frysk-core/frysk/bindir/ferror.java
@@ -64,8 +64,9 @@ public class ferror {
private static Pattern writePattern;
private static OptionGroup[] options() {
OptionGroup group = new OptionGroup("ferror options");
- group.add(new Option('e', "--error",
- "error regex to catch in double quotes -e \"<error string>\"") {
+ group.add(new Option("error", 'e',
+ "error regex to catch in double quotes",
+ "<error string>") {
public void parsed(String argument) throws OptionException {
writePattern = Pattern.compile(argument);
}
reply other threads:[~2008-04-10 10:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207824887.5343.44.camel@localhost.localdomain \
--to=mark@klomp.org \
--cc=frysk@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).