public inbox for
 help / color / mirror / Atom feed
* [patch] Make ferror use the right Option constructor
@ 2008-04-10 11:38 Mark Wielaard
  0 siblings, 0 replies; only message in thread
From: Mark Wielaard @ 2008-04-10 11:38 UTC (permalink / raw)
  To: frysk


The help text for ferror looked slightly strange:
ferror options:
  -e error regex to catch in double quotes -e "<error string>"      --error

Looking at the code revealed that it used the wrong Option constructor
(wrong order of arguments). This fixes it to use the Options(String,
char, String, String) constructor (long-option, short-option,
description, argument-description).

2008-04-10  Mark Wielaard  <>

    * (options): Use correct Options constructor.

No regressions with this patch.

There is one failure that seems to have been there for a while (bug

testFerrorTracesPID(frysk.bindir.TestFerror)junit.framework.AssertionFailedError: run until signal: assertSendAddCloneWaitForAcks(signals {SIGUSR1(10),SIGUSR2(12)}); outstanding: {SIGUSR2(12)}



diff --git a/frysk-core/frysk/bindir/ b/frysk-core/frysk/bindir/
index 06cb1ca..ed0cbdb 100644
--- a/frysk-core/frysk/bindir/
+++ b/frysk-core/frysk/bindir/
@@ -64,8 +64,9 @@ public class ferror {
     private static Pattern writePattern;
     private static OptionGroup[] options() {
        OptionGroup group = new OptionGroup("ferror options");
-       group.add(new Option('e', "--error",
-                            "error regex to catch in double quotes -e \"<error string>\"") {
+       group.add(new Option("error", 'e',
+                            "error regex to catch in double quotes",
+                            "<error string>") {
                public void parsed(String argument) throws OptionException {
                    writePattern = Pattern.compile(argument);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-04-10 10:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-10 11:38 [patch] Make ferror use the right Option constructor Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).