public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@cn.ibm.com>
To: frysk@sourceware.org
Subject: Re: Multi-Task Procs in the SourceWindow
Date: Tue, 10 Oct 2006 01:47:00 -0000	[thread overview]
Message-ID: <20061010014613.GD3152@GreenHouse.cn.ibm.com> (raw)
In-Reply-To: <1159978682.2010.10.camel@Warbird.Northern>

On Wed, Oct 04, 2006 at 12:18:00PM -0400, Mike Cvet wrote:
> I've just committed a large patch which allows the SourceWindow to
> handle processes with multiple threads. That is, it properly blocks and
> unblocks them, and if the source code is available, should display the
> source from each thread and highlight the appropriate lines properly.
> 
> Thanks to Tom's idea, it uses a TreeView widget to list each thread and
> their respective frames on the call stack.
> 
> I'm pretty sure that bugs exist! If you have some free time and want to
> check it out, I've attached an example test program. Please assign any
> breakage to me.
Hi, Mike,
I run it with the example in the attachment, and the SourceWindow
works fine to me(on x86 rawhide).  Thanks!

Here are some points that we could improve,
1) If we click one frame in StackWindow, appropriate lines are
highlighted, but the SourceWindow do *not* adjust the content in it to
display the highlighted lines, and always display source code from
line #1.  Could we make SourceWindow to refresh, and display the
highlighted lines in the middle of SourceWindows, when we click on frame?

2) When I click one frame, there are multiple lines are highlighted.
For example, If I click "baz" in StackWindow, line #42, #50, and #57
are highlighted at the same time.  Is it expected?  IMO, we could only
highlight the *current* frame, instead of call tree, which has been
displayed in StackWindow.

3) Multiple source file is not support.
If I put do_it() in tester1.c, and compile the test like this,
$ gcc -g tester1.c tester2.c -o test -lpthread

and then fire frysk, we could find do_it() in StackWindow, and the
line number is #11(the correct line number), but line #11 in tester2.c
is highlighted, instead of line #11 in teser1.c.

-- 
Yao Qi

  reply	other threads:[~2006-10-10  1:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-04 16:15 Mike Cvet
2006-10-10  1:47 ` Yao Qi [this message]
2006-10-10 19:13   ` Andrew Cagney
2006-10-10 19:46     ` Rick Moseley
2006-10-10 20:26   ` Mike Cvet
2006-10-16 11:59     ` Mark Wielaard
2006-10-16 13:45       ` Mike Cvet
2006-10-16 11:52 ` Mark Wielaard
2006-10-16 13:43   ` Mike Cvet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061010014613.GD3152@GreenHouse.cn.ibm.com \
    --to=qiyaoltc@cn.ibm.com \
    --cc=frysk@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).