[patch] --enable-maintainer-mode

[patch] --enable-maintainer-mode

[Jan Kratochvil]

[-- Attachment #1: Type: text/plain, Size: 79 bytes --]

Hi,

I believe I do not have CVS account on sources.redhat.com.


Regards,
Jan

[-- Attachment #2: frysk-cvs-enable-maintainer-mode.patch --]
[-- Type: text/plain, Size: 622 bytes --]

2006-11-12  Jan Kratochvil <jan.kratochvil@redhat.com>

	* configure.ac: Permit `--enable-maintainer-mode' (for updates by cvs).


Index: configure.ac
===================================================================
RCS file: /cvs/frysk/frysk-top/configure.ac,v
retrieving revision 1.13
diff -u -p -r1.13 configure.ac
--- configure.ac	5 Jan 2006 16:55:42 -0000	1.13
+++ configure.ac	12 Nov 2006 09:46:00 -0000
@@ -46,4 +46,5 @@ AM_INIT_AUTOMAKE([subdir-objects foreign
 AC_CONFIG_FILES([Makefile])
 AC_CONFIG_SUBDIRS([frysk-imports frysk-sys frysk-core frysk-gtk frysk-gui])
 AM_PROG_GCJ
+AM_MAINTAINER_MODE
 AC_OUTPUT

Re: [patch] --enable-maintainer-mode

[Andrew Cagney]

Hi Jan,

Building frysk always requires autoconf et.al., so I'm not sure why this 
is needed?

Andrew

Jan Kratochvil wrote:
> Hi,
>
> I believe I do not have CVS account on sources.redhat.com.
>
>
> Regards,
> Jan
>   
> ------------------------------------------------------------------------
>
> 2006-11-12  Jan Kratochvil <jan.kratochvil@redhat.com>
>
> 	* configure.ac: Permit `--enable-maintainer-mode' (for updates by cvs).
>
>
> Index: configure.ac
> ===================================================================
> RCS file: /cvs/frysk/frysk-top/configure.ac,v
> retrieving revision 1.13
> diff -u -p -r1.13 configure.ac
> --- configure.ac	5 Jan 2006 16:55:42 -0000	1.13
> +++ configure.ac	12 Nov 2006 09:46:00 -0000
> @@ -46,4 +46,5 @@ AM_INIT_AUTOMAKE([subdir-objects foreign
>  AC_CONFIG_FILES([Makefile])
>  AC_CONFIG_SUBDIRS([frysk-imports frysk-sys frysk-core frysk-gtk frysk-gui])
>  AM_PROG_GCJ
> +AM_MAINTAINER_MODE
>  AC_OUTPUT
>   

Re: [patch] --enable-maintainer-mode

[Jan Kratochvil]

Hi Andrew,

OK, please ignore this patch.

I wrongly assumed unusually missing `AM_MAINTAINER_MODE' results in the default
of `--disable-maintainer-mode' while the opposite is true.
The build error was probably due to some forgotten `make clean' or so.


Regards,
Jan


On Mon, 13 Nov 2006 16:49:49 +0100, Andrew Cagney wrote:
> Hi Jan,
> 
> Building frysk always requires autoconf et.al., so I'm not sure why this 
> is needed?
> 
> Andrew
> 
> Jan Kratochvil wrote:
> >Hi,
> >
> >I believe I do not have CVS account on sources.redhat.com.
> >
> >
> >Regards,
> >Jan
> >  
> >------------------------------------------------------------------------
> >
> >2006-11-12  Jan Kratochvil <jan.kratochvil@redhat.com>
> >
> >	* configure.ac: Permit `--enable-maintainer-mode' (for updates by 
> >	cvs).
> >
> >
> >Index: configure.ac
> >===================================================================
> >RCS file: /cvs/frysk/frysk-top/configure.ac,v
> >retrieving revision 1.13
> >diff -u -p -r1.13 configure.ac
> >--- configure.ac	5 Jan 2006 16:55:42 -0000	1.13
> >+++ configure.ac	12 Nov 2006 09:46:00 -0000
> >@@ -46,4 +46,5 @@ AM_INIT_AUTOMAKE([subdir-objects foreign
> > AC_CONFIG_FILES([Makefile])
> > AC_CONFIG_SUBDIRS([frysk-imports frysk-sys frysk-core frysk-gtk 
> > frysk-gui])
> > AM_PROG_GCJ
> >+AM_MAINTAINER_MODE
> > AC_OUTPUT
> >  

Re: [patch] --enable-maintainer-mode

[Andrew Cagney]

Jan Kratochvil wrote:
> Hi Andrew,
>
> OK, please ignore this patch.
>
> I wrongly assumed unusually missing `AM_MAINTAINER_MODE' results in the default
> of `--disable-maintainer-mode' while the opposite is true.
> The build error was probably due to some forgotten `make clean' or so.
>   

Ah, thats ok.  Yes, this is somewhat atypical for a tool-chain project, 
but then, having a clean slate makes doing this possible.  BTW, here's 
what automake has to say about maintainer mode:

26.2.2 `AM_MAINTAINER_MODE'
[...]

   Several years ago Franc,ois Pinard pointed out several arguments
against this `AM_MAINTAINER_MODE' macro.  Most of them relate to
insecurity.  By removing dependencies you get non-dependable builds:
change to sources files can have no effect on generated files and this
can be very confusing when unnoticed.  He adds that security shouldn't
be reserved to maintainers (what `--enable-maintainer-mode' suggests),
on the contrary.  If one user has to modify a `Makefile.am', then
either `Makefile.in' should be updated or a warning should be output
(this is what Automake uses `missing' for) but the last thing you want
is that nothing happens and the user doesn't notice it (this is what
happens when rebuild rules are disabled by `AM_MAINTAINER_MODE').

   Jim Meyering, the inventor of the `AM_MAINTAINER_MODE' macro was
swayed by Franc,ois's arguments, and got rid of `AM_MAINTAINER_MODE' in
all of his packages.

Andrew