From: Andrew Cagney <cagney@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: frysk@sourceware.org
Subject: Re: frysk-core/frysk/proc ChangeLog TestBreakpoint ...
Date: Mon, 11 Dec 2006 22:01:00 -0000 [thread overview]
Message-ID: <457DD513.40602@redhat.com> (raw)
In-Reply-To: <1160754997.3025.18.camel@dijkstra.wildebeest.org>
Going over very very old e-mail.
There was some sort of dead-lock between the code creating the
event-loop thread, and the code deleting it. It only occures, and then
only occasionally, when nothing happens in between.
The way to fix this though, isn't to chase after yet another nasty race
that is unrelated to what is being unit tested, but rather to look at
making that test single-threaded - I see that code has suffered from
other similar nasty races. Not being multi-threaded means there's one
less thing that can go wrong.
I also noticed that the test uses file descriptors to exchange messages
actions rather than signals. That's a more interesting idea, but does
mean integrating file-descriptors into the event loop - something I've
so far avoided.
Andrew
Mark Wielaard wrote:
> Hi Andrew,
>
> On Fri, 2006-10-13 at 09:51 -0400, Andrew Cagney wrote:
>
>> Mark Wielaard wrote:
>>
>>> I read that but it doesn't give an explanation for this change.
>>>
>>>
>> It stops the hang.
>>
>
> Yes, it claims that. But why did that hang happen and how does your
> change help? As far as I can see there isn't a change of functionality
> just a duplication of code. So please do explain the change a little
> more. When we understand the cause of the problem we might be able to
> fix it without needing to duplicate code.
>
> Thanks,
>
> Mark
>
>
prev parent reply other threads:[~2006-12-11 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061012145206.6642.qmail@sourceware.org>
2006-10-12 20:46 ` Mark Wielaard
2006-10-12 21:20 ` Andrew Cagney
2006-10-12 23:20 ` Mark Wielaard
2006-10-13 13:51 ` Andrew Cagney
2006-10-13 15:57 ` Mark Wielaard
2006-12-11 22:01 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457DD513.40602@redhat.com \
--to=cagney@redhat.com \
--cc=frysk@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).