Re: frysk-core/frysk/proc ChangeLog TestBreakpoint ...

Re: frysk-core/frysk/proc ChangeLog TestBreakpoint ...

[Mark Wielaard]

Hi Andrew,

On Thu, 2006-10-12 at 14:52 +0000, cagney@sourceware.org wrote:
> 	2006-10-12  Andrew Cagney  <cagney@redhat.com>
> 	
> 	* TestBreakpoints.java (setUp): Move code creating event loop from
> 	here ...
> 	(testHitAndRun, testInsertRemove, testAddLots): ... to here.
> 	(tearDown): Only shutdown the eventLoop when it is running.

This change doesn't make sense to me.
setUp() and tearDown() are called before and after every test, which is
why all common setup/teardown code is in those methods. Moving parts of
it into the individual tests makes the code harder to maintain imho.
Could you explain why you think it is necessary?

Also, could you please keep the file indentation (GNU style) please (*).

Thanks,

Mark

(*) For emacs the following will do it (in your .emacs) automagically:

(add-hook 'java-mode-hook
  (lambda ()
    (c-set-style "GNU")
    (c-set-offset 'inline-open 0)))

Re: frysk-core/frysk/proc ChangeLog TestBreakpoint ...

[Andrew Cagney]

Mark Wielaard wrote:
> Hi Andrew,
>
> On Thu, 2006-10-12 at 14:52 +0000, cagney@sourceware.org wrote:
>   
>> 	2006-10-12  Andrew Cagney  <cagney@redhat.com>
>> 	
>> 	* TestBreakpoints.java (setUp): Move code creating event loop from
>> 	here ...
>> 	(testHitAndRun, testInsertRemove, testAddLots): ... to here.
>> 	(tearDown): Only shutdown the eventLoop when it is running.
>>     
>
> This change doesn't make sense to me.
> setUp() and tearDown() are called before and after every test, which is
> why all common setup/teardown code is in those methods. Moving parts of
> it into the individual tests makes the code harder to maintain imho.
> Could you explain why you think it is necessary?
>
>   
See http://sourceware.org/bugzilla/show_bug.cgi?id=3354
You're already on the CC list.
> Also, could you please keep the file indentation (GNU style) please (*).
>   
That sounds like a bug in EMACS.

Andrew

Re: frysk-core/frysk/proc ChangeLog TestBreakpoint ...

[Mark Wielaard]

Hi Andrew,

On Thu, 2006-10-12 at 17:20 -0400, Andrew Cagney wrote:
> Mark Wielaard wrote:
> > This change doesn't make sense to me.
> > setUp() and tearDown() are called before and after every test, which is
> > why all common setup/teardown code is in those methods. Moving parts of
> > it into the individual tests makes the code harder to maintain imho.
> > Could you explain why you think it is necessary?
> >  
> See http://sourceware.org/bugzilla/show_bug.cgi?id=3354
> You're already on the CC list.

I read that but it doesn't give an explanation for this change.

> > Also, could you please keep the file indentation (GNU style) please (*).
> >   
> That sounds like a bug in EMACS.

Strangely enough the default emacs identation rules for java-mode are
not GNU. But it is easy to make it so by setting it explicitly in
your .emacs file.

Cheers,

Mark

Re: frysk-core/frysk/proc ChangeLog TestBreakpoint ...

[Andrew Cagney]

Mark Wielaard wrote:
>
> I read that but it doesn't give an explanation for this change.
>   
It stops the hang.
>>> Also, could you please keep the file indentation (GNU style) please (*).
>>>   
>>>       
>> That sounds like a bug in EMACS.
>>     
>
> Strangely enough the default emacs identation rules for java-mode are
> not GNU. But it is easy to make it so by setting it explicitly in
> your .emacs file.
>
>   
So either emacs, the GNU IDE flagship, doesn't comply to GNU Java coding 
standards, or the GNU Java coding standard doesn't actually comply to 
the coding standard as implicitly defined by EMACS?  Either way it is a 
bug, EMACS needs to default to a coding standard that meets GNU 
requirements, and not require EMACS users to pull hacks to get it to 
match.  Can this be fixed?

Andrew

Re: frysk-core/frysk/proc ChangeLog TestBreakpoint ...

[Mark Wielaard]

Hi Andrew,

On Fri, 2006-10-13 at 09:51 -0400, Andrew Cagney wrote:
> Mark Wielaard wrote:
> >
> > I read that but it doesn't give an explanation for this change.
> >   
> It stops the hang.

Yes, it claims that. But why did that hang happen and how does your
change help? As far as I can see there isn't a change of functionality
just a duplication of code. So please do explain the change a little
more. When we understand the cause of the problem we might be able to
fix it without needing to duplicate code.

Thanks,

Mark

Re: frysk-core/frysk/proc ChangeLog TestBreakpoint ...

[Andrew Cagney]

Going over very very old e-mail.

There was some sort of dead-lock between the code creating the 
event-loop thread, and the code deleting it.  It only occures, and then 
only occasionally, when nothing happens in between.

The way to fix this though, isn't to chase after yet another nasty race 
that is unrelated to what is being unit tested, but rather to look at 
making that test single-threaded - I see that code has suffered from 
other similar nasty races.  Not being multi-threaded means there's one 
less thing that can go wrong.

I also noticed that the test uses file descriptors to exchange messages 
actions rather than signals.  That's a more interesting idea, but does 
mean integrating file-descriptors into the event loop - something I've 
so far avoided.

Andrew

Mark Wielaard wrote:
> Hi Andrew,
>
> On Fri, 2006-10-13 at 09:51 -0400, Andrew Cagney wrote:
>   
>> Mark Wielaard wrote:
>>     
>>> I read that but it doesn't give an explanation for this change.
>>>   
>>>       
>> It stops the hang.
>>     
>
> Yes, it claims that. But why did that hang happen and how does your
> change help? As far as I can see there isn't a change of functionality
> just a duplication of code. So please do explain the change a little
> more. When we understand the cause of the problem we might be able to
> fix it without needing to duplicate code.
>
> Thanks,
>
> Mark
>
>