Re: frysk-common ./ChangeLog ./configure.ac ./Chan ...

Re: frysk-common ./ChangeLog ./configure.ac ./Chan ...

[Andrew Cagney]

Stepan,
I'm trying to understand this change, it appears to be restricting the 
building of 32-bit-on-64-bit tests to the frysk-core directory?  I'm not 
sure that that is a good idea.
Andrew

kasal@sourceware.org wrote:
> CVSROOT:	/cvs/frysk
> Module name:	frysk-common
> Changes by:	kasal@sourceware.org	2006-12-18 17:37:52
>
> Modified files:
> 	.              : ChangeLog configure.ac 
> 	.              : ChangeLog Makefile.gen.sh frysk-common.ac 
> 	m4             : frysk_do_arch32_test.m4 
>
> Log message:
> 	common/ChangeLog:
> 	* m4/frysk_do_arch32_test.m4 (--disable-arch32-tests): New
> 	option to skip building arch32 tests.
> 	* frysk-common.ac: Do not call FRYSK_DO_ARCH32_TEST.
> 	* Makefile.gen.sh: Do not use "if DO_ARCH32_TEST" for
> 	variables which can appear in packages without arch32 tests.
> 	(arch32_cflags_output): Removed, it was modified only in
> 	subshells, which was confusing.
> 	(arch32_cflag_name, arch32_as_cflag_name): Add comment.
> 	
> 	ChangeLog:
> 	* configure.ac: Call FRYSK_DO_ARCH32_TEST.
>
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/ChangeLog.diff?cvsroot=frysk&r1=1.280&r2=1.281
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/configure.ac.diff?cvsroot=frysk&r1=1.10&r2=1.11
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-common/ChangeLog.diff?cvsroot=frysk&r1=1.281&r2=1.282
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-common/Makefile.gen.sh.diff?cvsroot=frysk&r1=1.122&r2=1.123
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-common/frysk-common.ac.diff?cvsroot=frysk&r1=1.3&r2=1.4
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-common/m4/frysk_do_arch32_test.m4.diff?cvsroot=frysk&r1=1.1&r2=1.2
>
>   

Re: frysk-common ./ChangeLog ./configure.ac ./Chan ...

[Stepan Kasal]

Hello Andrew,

On Mon, Dec 18, 2006 at 01:36:47PM -0500, Andrew Cagney wrote:
> I'm trying to understand this change, it appears to be restricting the 
> building of 32-bit-on-64-bit tests to the frysk-core directory?

indeed.  To enable it for another frysk-foo, one would just add
	FRYSK_DO_ARCH32_TEST
to frysk-foo/configure.ac.
The small advantages of this change is that ./configure --help does not
show --disable-arch32-tests where it is not relevant.

I thought I have consulted this with you long ago, but now it seems I
have fancied this memory.

Shall I move FRYSK_DO_ARCH32_TEST back to frysk-common.ac?

Stepan

Re: frysk-common ./ChangeLog ./configure.ac ./Chan ...

[Andrew Cagney]

Stepan,

Yes, please add back FRYSK_DO_ARCH32_TEST so that any of the directories 
can build 32-bit executables, and not just frysk-core.

Andrew

Stepan Kasal wrote:
> Hello Andrew,
>
> On Mon, Dec 18, 2006 at 01:36:47PM -0500, Andrew Cagney wrote:
>   
>> I'm trying to understand this change, it appears to be restricting the 
>> building of 32-bit-on-64-bit tests to the frysk-core directory?
>>     
>
> indeed.  To enable it for another frysk-foo, one would just add
> 	FRYSK_DO_ARCH32_TEST
> to frysk-foo/configure.ac.
> The small advantages of this change is that ./configure --help does not
> show --disable-arch32-tests where it is not relevant.
>
> I thought I have consulted this with you long ago, but now it seems I
> have fancied this memory.
>
> Shall I move FRYSK_DO_ARCH32_TEST back to frysk-common.ac?
>
> Stepan
>