* Re: frysk-core/frysk util/TestFStack.java util/Sta ...
[not found] <20061218182438.13405.qmail@sourceware.org>
@ 2006-12-19 10:54 ` Mark Wielaard
2006-12-19 16:45 ` Nurdin Premji
0 siblings, 1 reply; 3+ messages in thread
From: Mark Wielaard @ 2006-12-19 10:54 UTC (permalink / raw)
To: frysk; +Cc: npremji
Hi,
On Mon, 2006-12-18 at 18:24 +0000, npremji@sourceware.org wrote:
> * ProcBlockAction.java (ProcBlockAction): Added call to addFailed if proc has bad ownership.
> [...]
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/ProcBlockAction.java.diff?cvsroot=frysk&r1=1.6&r2=1.7
> @@ -141,7 +140,7 @@
>
> if (! isOwned)
> {
> - // ("Process " + proc + " is not owned by user/group.");
> + addFailed(proc, new Throwable("Process " + proc + " is not owned by user/group."));
> }
>
> taskList = proc.getTasks();
Should there be a return statement after the addFailed()? So we don't
try to do any other work, like getting the task list and trying to do a
requestAdd() (which will of course also fail)?
Cheers,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: frysk-core/frysk util/TestFStack.java util/Sta ...
2006-12-19 10:54 ` frysk-core/frysk util/TestFStack.java util/Sta Mark Wielaard
@ 2006-12-19 16:45 ` Nurdin Premji
2006-12-20 18:58 ` Andrew Cagney
0 siblings, 1 reply; 3+ messages in thread
From: Nurdin Premji @ 2006-12-19 16:45 UTC (permalink / raw)
To: Mark Wielaard; +Cc: frysk, npremji
On Tue, 2006-12-19 at 11:54 +0100, Mark Wielaard wrote:
> Hi,
>
> On Mon, 2006-12-18 at 18:24 +0000, npremji@sourceware.org wrote:
> > * ProcBlockAction.java (ProcBlockAction): Added call to addFailed if proc has bad ownership.
> > [...]
> > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/ProcBlockAction.java.diff?cvsroot=frysk&r1=1.6&r2=1.7
>
> > @@ -141,7 +140,7 @@
> >
> > if (! isOwned)
> > {
> > - // ("Process " + proc + " is not owned by user/group.");
> > + addFailed(proc, new Throwable("Process " + proc + " is not owned by user/group."));
> > }
> >
> > taskList = proc.getTasks();
>
> Should there be a return statement after the addFailed()? So we don't
> try to do any other work, like getting the task list and trying to do a
> requestAdd() (which will of course also fail)?
>
> Cheers,
>
> Mark
>
Yup, done. :)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: frysk-core/frysk util/TestFStack.java util/Sta ...
2006-12-19 16:45 ` Nurdin Premji
@ 2006-12-20 18:58 ` Andrew Cagney
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Cagney @ 2006-12-20 18:58 UTC (permalink / raw)
To: Nurdin Premji; +Cc: Mark Wielaard, frysk
Nurdin,
FYI, I created:
http://sourceware.org/bugzilla/show_bug.cgi?id=3774
against this code. The isOwned test won't work, the code is wrong :-(
The problem is that between the time the test is made (and say
succeeds), and then the attach request is made, the process could alter
its state in someway that still makes the attach invalid (execing a
setuid program for instance).
Because of this, the code must _always_ attempt the attach and respond
using failure notifications from the core.
Andrew
Nurdin Premji wrote:
> On Tue, 2006-12-19 at 11:54 +0100, Mark Wielaard wrote:
>
>> Hi,
>>
>> On Mon, 2006-12-18 at 18:24 +0000, npremji@sourceware.org wrote:
>>
>>> * ProcBlockAction.java (ProcBlockAction): Added call to addFailed if proc has bad ownership.
>>> [...]
>>> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/ProcBlockAction.java.diff?cvsroot=frysk&r1=1.6&r2=1.7
>>>
>>> @@ -141,7 +140,7 @@
>>>
>>> if (! isOwned)
>>> {
>>> - // ("Process " + proc + " is not owned by user/group.");
>>> + addFailed(proc, new Throwable("Process " + proc + " is not owned by user/group."));
>>> }
>>>
>>> taskList = proc.getTasks();
>>>
>> Should there be a return statement after the addFailed()? So we don't
>> try to do any other work, like getting the task list and trying to do a
>> requestAdd() (which will of course also fail)?
>>
>> Cheers,
>>
>> Mark
>>
>>
>
> Yup, done. :)
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-12-20 18:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20061218182438.13405.qmail@sourceware.org>
2006-12-19 10:54 ` frysk-core/frysk util/TestFStack.java util/Sta Mark Wielaard
2006-12-19 16:45 ` Nurdin Premji
2006-12-20 18:58 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).