public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
* @author and TODO make check cry (Was: frysk-gui/frysk/gui ChangeLog glade/procpop.gl ...)
       [not found] <20070109162624.9923.qmail@sourceware.org>
@ 2007-01-10 12:10 ` Mark Wielaard
  2007-01-10 15:04   ` Sami Wagiaalla
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Wielaard @ 2007-01-10 12:10 UTC (permalink / raw)
  To: frysk; +Cc: swagiaal

Hi,

On Tue, Jan 09, 2007 at 04:26:24PM -0000, swagiaal@sourceware.org wrote:
> +/**
> + * 
> + * @author swagiaal
> + *
[...]
> +    // TODO Auto-generated method stub
> +    return false;

This makes make check fail because it has new checks against @author
and TODO tagging in source. I could easily resolve the @author thing.
But since I don't know the gui code too well I didn't know whether the
TODO stubs were checked in by accident or that they really still are
to be done.

Please do run make check always before checking things in.

Cheers,

Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: @author and TODO make check cry (Was: frysk-gui/frysk/gui ChangeLog  glade/procpop.gl ...)
  2007-01-10 12:10 ` @author and TODO make check cry (Was: frysk-gui/frysk/gui ChangeLog glade/procpop.gl ...) Mark Wielaard
@ 2007-01-10 15:04   ` Sami Wagiaalla
  0 siblings, 0 replies; 2+ messages in thread
From: Sami Wagiaalla @ 2007-01-10 15:04 UTC (permalink / raw)
  To: Mark Wielaard; +Cc: frysk, swagiaal


> This makes make check fail because it has new checks against @author
> and TODO tagging in source. I could easily resolve the @author thing.
> But since I don't know the gui code too well I didn't know whether the
> TODO stubs were checked in by accident or that they really still are
> to be done.
>   
I will make the fixes and commit them.
> Please do run make check always before checking things in.
>   
Will do :)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-01-10 15:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20070109162624.9923.qmail@sourceware.org>
2007-01-10 12:10 ` @author and TODO make check cry (Was: frysk-gui/frysk/gui ChangeLog glade/procpop.gl ...) Mark Wielaard
2007-01-10 15:04   ` Sami Wagiaalla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).