Re: frysk-core ./Makefile.am ./ChangeLog frysk/pkg ...

Re: frysk-core ./Makefile.am ./ChangeLog frysk/pkg ...

[Mark Wielaard]

Hi Nurdin,

On Thu, 2007-02-01 at 19:53 +0000, npremji@sourceware.org wrote:
> 	frysk
> 	/pkglibdir/CL
> 	* funit-stacktrace-asm.S: Added.
> 	* funit-stacktrace-static-asm.S: Added.

I am unable to get these to compile on my x86_64 box.

gcc  -g -O -c -o
frysk/pkglibdir/funit-stackframe-asm.o ../../frysk/frysk-core/frysk/pkglibdir/funit-stackframe-asm.S
funit-stackframe.c: Assembler messages:
funit-stackframe.c:6: Error: suffix or operands invalid for `push'
funit-stackframe.c:10: Error: suffix or operands invalid for `pop'
funit-stackframe.c:17: Error: suffix or operands invalid for `push'
funit-stackframe.c:18: Error: suffix or operands invalid for `push'
funit-stackframe.c:20: Error: suffix or operands invalid for `push'
funit-stackframe.c:23: Error: suffix or operands invalid for `pop'
funit-stackframe.c:24: Error: suffix or operands invalid for `pop'
make[1]: *** [frysk/pkglibdir/funit-stackframe-asm.o] Error 1

It seems to compile fine on x86 though.

But I don't know how to fix this. Any clue?

Thanks,

Mark

Re: frysk-core ./Makefile.am ./ChangeLog frysk/pkg ...

[Andrew Cagney]

Try now.
frysk-core/frysk/pkglibdir/funit-asm.h has been re-written.  The x86-64 
assembler might be correct.  Regardless, hopefully, the new style is 
sufficiently flexible for an easy fix.
Andrew

Mark Wielaard wrote:
> Hi Nurdin,
>
> On Thu, 2007-02-01 at 19:53 +0000, npremji@sourceware.org wrote:
>   
>> 	frysk
>> 	/pkglibdir/CL
>> 	* funit-stacktrace-asm.S: Added.
>> 	* funit-stacktrace-static-asm.S: Added.
>>     
>
> I am unable to get these to compile on my x86_64 box.
>
> gcc  -g -O -c -o
> frysk/pkglibdir/funit-stackframe-asm.o ../../frysk/frysk-core/frysk/pkglibdir/funit-stackframe-asm.S
> funit-stackframe.c: Assembler messages:
> funit-stackframe.c:6: Error: suffix or operands invalid for `push'
> funit-stackframe.c:10: Error: suffix or operands invalid for `pop'
> funit-stackframe.c:17: Error: suffix or operands invalid for `push'
> funit-stackframe.c:18: Error: suffix or operands invalid for `push'
> funit-stackframe.c:20: Error: suffix or operands invalid for `push'
> funit-stackframe.c:23: Error: suffix or operands invalid for `pop'
> funit-stackframe.c:24: Error: suffix or operands invalid for `pop'
> make[1]: *** [frysk/pkglibdir/funit-stackframe-asm.o] Error 1
>
> It seems to compile fine on x86 though.
>
> But I don't know how to fix this. Any clue?
>
> Thanks,
>
> Mark
>
>   

Re: frysk-core ./Makefile.am ./ChangeLog frysk/pkg ...

[Mark Wielaard]

Hi Andrew,

On Fri, 2007-02-02 at 17:26 -0500, Andrew Cagney wrote:
> Try now.
> frysk-core/frysk/pkglibdir/funit-asm.h has been re-written.  The x86-64 
> assembler might be correct.  Regardless, hopefully, the new style is 
> sufficiently flexible for an easy fix.

It looks like the movl should just be a mov on x86_64. But I am unable
to test since I get (on both x86 and x86_64) the following error:

make[2]: *** No rule to make target `frysk/pkglibdir/funit-stackframe',
needed by `frysk/pkglibdir/funit-stackframe-nodebug'.  Stop.

There are a couple of Makefile rules for
funit-stackframe-asm[-debug|-stripped] but none for the none -asm
versions. How should they be generated?

Thanks,

Mark

Re: frysk-core ./Makefile.am ./ChangeLog frysk/pkg ...

[Mark Wielaard]

Hi Andrew,

On Sat, 2007-02-03 at 02:13 +0100, Mark Wielaard wrote:
> On Fri, 2007-02-02 at 17:26 -0500, Andrew Cagney wrote:
> > Try now.
> > frysk-core/frysk/pkglibdir/funit-asm.h has been re-written.  The x86-64 
> > assembler might be correct.  Regardless, hopefully, the new style is 
> > sufficiently flexible for an easy fix.
> 
> It looks like the movl should just be a mov on x86_64.

I made that change:

2007-02-05  Mark Wielaard  <mark@klomp.org>

       * funit-asm.h (STORE __x86_64__): Use mov, not movl.

>  But I am unable
> to test since I get (on both x86 and x86_64) the following error:
>
> make[2]: *** No rule to make target `frysk/pkglibdir/funit-stackframe',
> needed by `frysk/pkglibdir/funit-stackframe-nodebug'.  Stop.
> 
> There are a couple of Makefile rules for
> funit-stackframe-asm[-debug|-stripped] but none for the none -asm
> versions. How should they be generated?

Thanks for fixing those. I have disabled the associated tests and filed
a bug report for them.

2007-02-05  Mark Wielaard  <mark@klomp.org>

       * TestStackFrame.java (testDebug): Mark as broken #3968.
       (testNoDebug): Likewise.
       (testStripped): Likewise.
       (testStaticDebug): Likewise.
       (testStaticNoDebug): Likewise.
       (testStaticStripped): Likewise.

Thanks,

Mark

Re: frysk-core ./Makefile.am ./ChangeLog frysk/pkg ...

[Mike Cvet]

> Thanks for fixing those. I have disabled the associated tests and filed
> a bug report for them.
>
> 2007-02-05  Mark Wielaard  <mark@klomp.org>
>
>        * TestStackFrame.java (testDebug): Mark as broken #3968.
>        (testNoDebug): Likewise.
>        (testStripped): Likewise.
>        (testStaticDebug): Likewise.
>        (testStaticNoDebug): Likewise.
>        (testStaticStripped): Likewise.
>
> Thanks,
>
> Mark
>
>   

My fault, sorry.

- Mike