* New syscalls
@ 2007-02-08 12:21 Mark Wielaard
2007-02-08 16:48 ` Andrew Cagney
0 siblings, 1 reply; 2+ messages in thread
From: Mark Wielaard @ 2007-02-08 12:21 UTC (permalink / raw)
To: frysk
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
Hi,
The latest AuditLibs pointed out that there are some new syscalls for
IA32 and PowerPC. This patch adds them and changes the test to check
that we know at least the number of syscalls that auditlib knows about.
2007-02-08 Mark Wielaard <mark@klomp.org>
* LinuxIa32Syscall.java (syscallList): Add getcpu and epoll_pwait.
* LinuxPowerPCSyscall.java (syscallList): Add move_pages.
* TestSyscallsWithAudit.java (syscallTest): Change test to up to
at least highest number in auditlib.
It might be a good idea to better integrate the names and numbers as
reported by auditlib on the users system. Unfortunately auditlib doesn't
know all the details we need, so we still need to augment the list with
extra info (like whether or not the call returns, parameter list, etc).
Committed,
Mark
[-- Attachment #2: syscall.patch --]
[-- Type: text/x-patch, Size: 2306 bytes --]
Index: frysk-core/frysk/proc/LinuxIa32Syscall.java
===================================================================
RCS file: /cvs/frysk/frysk-core/frysk/proc/LinuxIa32Syscall.java,v
retrieving revision 1.5
diff -u -r1.5 LinuxIa32Syscall.java
--- frysk-core/frysk/proc/LinuxIa32Syscall.java 4 Dec 2006 20:53:55 -0000 1.5
+++ frysk-core/frysk/proc/LinuxIa32Syscall.java 8 Feb 2007 11:56:52 -0000
@@ -440,7 +440,9 @@
new Ia32Syscall ("sync_file_range", 314),
new Ia32Syscall ("tee", 315),
new Ia32Syscall ("vmsplice", 316),
- new Ia32Syscall ("move_pages", 317)
+ new Ia32Syscall ("move_pages", 317),
+ new Ia32Syscall ("getcpu", 318),
+ new Ia32Syscall ("epoll_pwait", 319)
};
Index: frysk-core/frysk/proc/LinuxPowerPCSyscall.java
===================================================================
RCS file: /cvs/frysk/frysk-core/frysk/proc/LinuxPowerPCSyscall.java,v
retrieving revision 1.5
diff -u -r1.5 LinuxPowerPCSyscall.java
--- frysk-core/frysk/proc/LinuxPowerPCSyscall.java 4 Dec 2006 20:53:55 -0000 1.5
+++ frysk-core/frysk/proc/LinuxPowerPCSyscall.java 8 Feb 2007 11:56:52 -0000
@@ -429,7 +429,8 @@
new PowerPCSyscall ("fchmodat", 297),
new PowerPCSyscall ("faccessat", 298),
new PowerPCSyscall ("get_robust_list", 299),
- new PowerPCSyscall ("set_robust_list", 300)
+ new PowerPCSyscall ("set_robust_list", 300),
+ new PowerPCSyscall ("move_pages", 301)
};
static class SocketSubSyscall
Index: frysk/proc/TestSyscallsWithAudit.java
===================================================================
RCS file: /cvs/frysk/frysk-core/frysk/proc/TestSyscallsWithAudit.java,v
retrieving revision 1.6
diff -u -r1.6 TestSyscallsWithAudit.java
--- frysk/proc/TestSyscallsWithAudit.java 14 Oct 2006 22:25:13 -0000 1.6
+++ frysk/proc/TestSyscallsWithAudit.java 8 Feb 2007 12:11:03 -0000
@@ -126,7 +126,8 @@
assertNull("MAX_SYSCALL_NUM", AuditLibs.syscallToName(MAX_SYSCALL_NUM,
machine));
- // We should have names up to the highest number auditlib knows about.
- assertEquals("max-syscall-num", highestNum, syscallList.length - 1);
+ // We should have names up to at least the highest number auditlib
+ // knows about.
+ assertTrue("max-syscall-num", highestNum <= syscallList.length - 1);
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: New syscalls
2007-02-08 12:21 New syscalls Mark Wielaard
@ 2007-02-08 16:48 ` Andrew Cagney
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cagney @ 2007-02-08 16:48 UTC (permalink / raw)
To: Mark Wielaard; +Cc: frysk
Sami, Mark,
Nice catch. That check is doing its job (Now if only this was all in
an xml file ;-).
Andrew
Mark Wielaard wrote:
> Hi,
>
> The latest AuditLibs pointed out that there are some new syscalls for
> IA32 and PowerPC. This patch adds them and changes the test to check
> that we know at least the number of syscalls that auditlib knows about.
>
> 2007-02-08 Mark Wielaard <mark@klomp.org>
>
> * LinuxIa32Syscall.java (syscallList): Add getcpu and epoll_pwait.
> * LinuxPowerPCSyscall.java (syscallList): Add move_pages.
> * TestSyscallsWithAudit.java (syscallTest): Change test to up to
> at least highest number in auditlib.
>
> It might be a good idea to better integrate the names and numbers as
> reported by auditlib on the users system. Unfortunately auditlib doesn't
> know all the details we need, so we still need to augment the list with
> extra info (like whether or not the call returns, parameter list, etc).
>
> Committed,
>
> Mark
>
> ------------------------------------------------------------------------
>
> Index: frysk-core/frysk/proc/LinuxIa32Syscall.java
> ===================================================================
> RCS file: /cvs/frysk/frysk-core/frysk/proc/LinuxIa32Syscall.java,v
> retrieving revision 1.5
> diff -u -r1.5 LinuxIa32Syscall.java
> --- frysk-core/frysk/proc/LinuxIa32Syscall.java 4 Dec 2006 20:53:55 -0000 1.5
> +++ frysk-core/frysk/proc/LinuxIa32Syscall.java 8 Feb 2007 11:56:52 -0000
> @@ -440,7 +440,9 @@
> new Ia32Syscall ("sync_file_range", 314),
> new Ia32Syscall ("tee", 315),
> new Ia32Syscall ("vmsplice", 316),
> - new Ia32Syscall ("move_pages", 317)
> + new Ia32Syscall ("move_pages", 317),
> + new Ia32Syscall ("getcpu", 318),
> + new Ia32Syscall ("epoll_pwait", 319)
> };
>
>
> Index: frysk-core/frysk/proc/LinuxPowerPCSyscall.java
> ===================================================================
> RCS file: /cvs/frysk/frysk-core/frysk/proc/LinuxPowerPCSyscall.java,v
> retrieving revision 1.5
> diff -u -r1.5 LinuxPowerPCSyscall.java
> --- frysk-core/frysk/proc/LinuxPowerPCSyscall.java 4 Dec 2006 20:53:55 -0000 1.5
> +++ frysk-core/frysk/proc/LinuxPowerPCSyscall.java 8 Feb 2007 11:56:52 -0000
> @@ -429,7 +429,8 @@
> new PowerPCSyscall ("fchmodat", 297),
> new PowerPCSyscall ("faccessat", 298),
> new PowerPCSyscall ("get_robust_list", 299),
> - new PowerPCSyscall ("set_robust_list", 300)
> + new PowerPCSyscall ("set_robust_list", 300),
> + new PowerPCSyscall ("move_pages", 301)
> };
>
> static class SocketSubSyscall
> Index: frysk/proc/TestSyscallsWithAudit.java
> ===================================================================
> RCS file: /cvs/frysk/frysk-core/frysk/proc/TestSyscallsWithAudit.java,v
> retrieving revision 1.6
> diff -u -r1.6 TestSyscallsWithAudit.java
> --- frysk/proc/TestSyscallsWithAudit.java 14 Oct 2006 22:25:13 -0000 1.6
> +++ frysk/proc/TestSyscallsWithAudit.java 8 Feb 2007 12:11:03 -0000
> @@ -126,7 +126,8 @@
> assertNull("MAX_SYSCALL_NUM", AuditLibs.syscallToName(MAX_SYSCALL_NUM,
> machine));
>
> - // We should have names up to the highest number auditlib knows about.
> - assertEquals("max-syscall-num", highestNum, syscallList.length - 1);
> + // We should have names up to at least the highest number auditlib
> + // knows about.
> + assertTrue("max-syscall-num", highestNum <= syscallList.length - 1);
> }
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-08 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-08 12:21 New syscalls Mark Wielaard
2007-02-08 16:48 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).