From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20136 invoked by alias); 8 Feb 2007 16:48:53 -0000 Received: (qmail 19953 invoked by uid 22791); 8 Feb 2007 16:48:49 -0000 X-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 Feb 2007 16:48:36 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l18GmWMg020464; Thu, 8 Feb 2007 11:48:32 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l18GmWDp032168; Thu, 8 Feb 2007 11:48:32 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l18GmUKh016183; Thu, 8 Feb 2007 11:48:30 -0500 Message-ID: <45CB5459.2040604@redhat.com> Date: Thu, 08 Feb 2007 16:48:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.9 (X11/20070102) MIME-Version: 1.0 To: Mark Wielaard CC: frysk@sourceware.org Subject: Re: New syscalls References: <1170937253.3024.3.camel@hermans.wildebeest.org> In-Reply-To: <1170937253.3024.3.camel@hermans.wildebeest.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00099.txt.bz2 Sami, Mark, Nice catch. That check is doing its job (Now if only this was all in an xml file ;-). Andrew Mark Wielaard wrote: > Hi, > > The latest AuditLibs pointed out that there are some new syscalls for > IA32 and PowerPC. This patch adds them and changes the test to check > that we know at least the number of syscalls that auditlib knows about. > > 2007-02-08 Mark Wielaard > > * LinuxIa32Syscall.java (syscallList): Add getcpu and epoll_pwait. > * LinuxPowerPCSyscall.java (syscallList): Add move_pages. > * TestSyscallsWithAudit.java (syscallTest): Change test to up to > at least highest number in auditlib. > > It might be a good idea to better integrate the names and numbers as > reported by auditlib on the users system. Unfortunately auditlib doesn't > know all the details we need, so we still need to augment the list with > extra info (like whether or not the call returns, parameter list, etc). > > Committed, > > Mark > > ------------------------------------------------------------------------ > > Index: frysk-core/frysk/proc/LinuxIa32Syscall.java > =================================================================== > RCS file: /cvs/frysk/frysk-core/frysk/proc/LinuxIa32Syscall.java,v > retrieving revision 1.5 > diff -u -r1.5 LinuxIa32Syscall.java > --- frysk-core/frysk/proc/LinuxIa32Syscall.java 4 Dec 2006 20:53:55 -0000 1.5 > +++ frysk-core/frysk/proc/LinuxIa32Syscall.java 8 Feb 2007 11:56:52 -0000 > @@ -440,7 +440,9 @@ > new Ia32Syscall ("sync_file_range", 314), > new Ia32Syscall ("tee", 315), > new Ia32Syscall ("vmsplice", 316), > - new Ia32Syscall ("move_pages", 317) > + new Ia32Syscall ("move_pages", 317), > + new Ia32Syscall ("getcpu", 318), > + new Ia32Syscall ("epoll_pwait", 319) > }; > > > Index: frysk-core/frysk/proc/LinuxPowerPCSyscall.java > =================================================================== > RCS file: /cvs/frysk/frysk-core/frysk/proc/LinuxPowerPCSyscall.java,v > retrieving revision 1.5 > diff -u -r1.5 LinuxPowerPCSyscall.java > --- frysk-core/frysk/proc/LinuxPowerPCSyscall.java 4 Dec 2006 20:53:55 -0000 1.5 > +++ frysk-core/frysk/proc/LinuxPowerPCSyscall.java 8 Feb 2007 11:56:52 -0000 > @@ -429,7 +429,8 @@ > new PowerPCSyscall ("fchmodat", 297), > new PowerPCSyscall ("faccessat", 298), > new PowerPCSyscall ("get_robust_list", 299), > - new PowerPCSyscall ("set_robust_list", 300) > + new PowerPCSyscall ("set_robust_list", 300), > + new PowerPCSyscall ("move_pages", 301) > }; > > static class SocketSubSyscall > Index: frysk/proc/TestSyscallsWithAudit.java > =================================================================== > RCS file: /cvs/frysk/frysk-core/frysk/proc/TestSyscallsWithAudit.java,v > retrieving revision 1.6 > diff -u -r1.6 TestSyscallsWithAudit.java > --- frysk/proc/TestSyscallsWithAudit.java 14 Oct 2006 22:25:13 -0000 1.6 > +++ frysk/proc/TestSyscallsWithAudit.java 8 Feb 2007 12:11:03 -0000 > @@ -126,7 +126,8 @@ > assertNull("MAX_SYSCALL_NUM", AuditLibs.syscallToName(MAX_SYSCALL_NUM, > machine)); > > - // We should have names up to the highest number auditlib knows about. > - assertEquals("max-syscall-num", highestNum, syscallList.length - 1); > + // We should have names up to at least the highest number auditlib > + // knows about. > + assertTrue("max-syscall-num", highestNum <= syscallList.length - 1); > } > } >