From: Andrew Cagney <cagney@redhat.com>
To: frysk@sourceware.org
Subject: Re: frysk-core/frysk cli/ChangeLog cli/hpd/CLI.jav ...
Date: Thu, 08 Feb 2007 17:29:00 -0000 [thread overview]
Message-ID: <45CB5DFB.6080009@redhat.com> (raw)
In-Reply-To: <20070207200921.7528.qmail@sourceware.org>
Tim,
One suggestion here; see:
http://sourceware.org/bugzilla/show_bug.cgi?id=3895 for the issue.
Instead of a separate addHelp method and help list; can each command
(possibly grouped into a few classes) take direct responsibility, and
using a single call, register itself both with help and with the command
line.
Andrew
>
> * hpd/CLI.java (attachedObserver): Remove.
> (runState, runStateObserver, AttachHandler, DetachHandler): Start
> and stop processes using RunState object.
> (BreakpointHandler, DeleteBreakpointHandler): Handlers for
> manipulating source breakpoints.
> (GoHandler, HaltHandler): Handlers for starting and stopping a
> process.
> (CLI constructor): Add new handlers to handler table.
> (RunStateObserver): New local class for interacting with RunState.
> * hpd/UserHelp.java (addHelp): Convenience function.
> (UserHelp constructor): Use it. Add help for "go" and "halt" commands.
>
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/cli/ChangeLog.diff?cvsroot=frysk&r1=1.63&r2=1.64
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/cli/hpd/CLI.java.diff?cvsroot=frysk&r1=1.36&r2=1.37
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/cli/hpd/UserHelp.java.diff?cvsroot=frysk&r1=1.7&r2=1.8
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/rt/ChangeLog.diff?cvsroot=frysk&r1=1.126&r2=1.127
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/rt/RunState.java.diff?cvsroot=frysk&r1=1.18&r2=1.19
>
>
parent reply other threads:[~2007-02-08 17:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20070207200921.7528.qmail@sourceware.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45CB5DFB.6080009@redhat.com \
--to=cagney@redhat.com \
--cc=frysk@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).