Re: frysk-core/frysk cli/ChangeLog cli/hpd/CLI.jav ...

Re: frysk-core/frysk cli/ChangeLog cli/hpd/CLI.jav ...

[Andrew Cagney]

Tim,

One suggestion here; see: 
http://sourceware.org/bugzilla/show_bug.cgi?id=3895 for the issue.
Instead of a separate addHelp method and help list; can each command 
(possibly grouped into a few classes) take direct responsibility, and 
using a single call, register itself both with help and with the command 
line.

Andrew

> 	
> 	* hpd/CLI.java (attachedObserver): Remove.
> 	(runState, runStateObserver, AttachHandler, DetachHandler): Start
> 	and stop processes using RunState object.
> 	(BreakpointHandler, DeleteBreakpointHandler): Handlers for
> 	manipulating source breakpoints.
> 	(GoHandler, HaltHandler): Handlers for starting and stopping a
> 	process.
> 	(CLI constructor): Add new handlers to handler table.
> 	(RunStateObserver): New local class for interacting with RunState.
> 	* hpd/UserHelp.java (addHelp): Convenience function.
> 	(UserHelp constructor): Use it. Add help for "go" and "halt" commands.
>
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/cli/ChangeLog.diff?cvsroot=frysk&r1=1.63&r2=1.64
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/cli/hpd/CLI.java.diff?cvsroot=frysk&r1=1.36&r2=1.37
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/cli/hpd/UserHelp.java.diff?cvsroot=frysk&r1=1.7&r2=1.8
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/rt/ChangeLog.diff?cvsroot=frysk&r1=1.126&r2=1.127
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/rt/RunState.java.diff?cvsroot=frysk&r1=1.18&r2=1.19
>
>