From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25598 invoked by alias); 8 Feb 2007 17:29:45 -0000 Received: (qmail 25590 invoked by uid 22791); 8 Feb 2007 17:29:45 -0000 X-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 Feb 2007 17:29:34 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l18HTVwg012230 for ; Thu, 8 Feb 2007 12:29:31 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l18HTVtS013402 for ; Thu, 8 Feb 2007 12:29:31 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l18HTU2T028309 for ; Thu, 8 Feb 2007 12:29:30 -0500 Message-ID: <45CB5DFB.6080009@redhat.com> Date: Thu, 08 Feb 2007 17:29:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.9 (X11/20070102) MIME-Version: 1.0 To: frysk@sourceware.org Subject: Re: frysk-core/frysk cli/ChangeLog cli/hpd/CLI.jav ... References: <20070207200921.7528.qmail@sourceware.org> In-Reply-To: <20070207200921.7528.qmail@sourceware.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00101.txt.bz2 Tim, One suggestion here; see: http://sourceware.org/bugzilla/show_bug.cgi?id=3895 for the issue. Instead of a separate addHelp method and help list; can each command (possibly grouped into a few classes) take direct responsibility, and using a single call, register itself both with help and with the command line. Andrew > > * hpd/CLI.java (attachedObserver): Remove. > (runState, runStateObserver, AttachHandler, DetachHandler): Start > and stop processes using RunState object. > (BreakpointHandler, DeleteBreakpointHandler): Handlers for > manipulating source breakpoints. > (GoHandler, HaltHandler): Handlers for starting and stopping a > process. > (CLI constructor): Add new handlers to handler table. > (RunStateObserver): New local class for interacting with RunState. > * hpd/UserHelp.java (addHelp): Convenience function. > (UserHelp constructor): Use it. Add help for "go" and "halt" commands. > > Patches: > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/cli/ChangeLog.diff?cvsroot=frysk&r1=1.63&r2=1.64 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/cli/hpd/CLI.java.diff?cvsroot=frysk&r1=1.36&r2=1.37 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/cli/hpd/UserHelp.java.diff?cvsroot=frysk&r1=1.7&r2=1.8 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/rt/ChangeLog.diff?cvsroot=frysk&r1=1.126&r2=1.127 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/rt/RunState.java.diff?cvsroot=frysk&r1=1.18&r2=1.19 > >