Re: frysk-imports/elfutils src/ranlib.c src/Change ...

Re: frysk-imports/elfutils src/ranlib.c src/Change ...

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 2129 bytes --]

Hi Nurdin,

On Thu, 2007-02-15 at 20:52 +0000, npremji@sourceware.org wrote:
> 	elfutils/tests : run-elflint-test.sh ChangeLog 
> 	                 run-ranlib-test2.sh Makefile.am 
> [...]
> Log message:
> 	Fix elfutils conflicts.
> 
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/elfutils/tests/Makefile.am.diff?cvsroot=frysk&r1=1.8&r2=1.9
> diff -u -r1.8 -r1.9
> --- frysk-imports/elfutils/tests/Makefile.am	2007/02/15 19:51:34	1.8
> +++ frysk-imports/elfutils/tests/Makefile.am	2007/02/15 20:52:19	1.9
> @@ -58,7 +58,7 @@
>  		  get-aranges allfcts line2addr addrscopes funcscopes \
>  		  show-abbrev hash newscn ecp dwflmodtest \
>  		  find-prologues funcretval allregs rdwrmmap 
> -#		  dwfl-bug-addr-overflow
> +		  dwfl-bug-addr-overflow arls
>  # get-ciefde
>  asm_TESTS = asm-tst1 asm-tst2 asm-tst3 asm-tst4 asm-tst5 \
>  	    asm-tst6 asm-tst7 asm-tst8 asm-tst9
> @@ -75,8 +75,8 @@
>  	run-ranlib-test2.sh run-ranlib-test3.sh run-ranlib-test4.sh \
>  	run-addrscopes.sh run-strings-test.sh run-funcscopes.sh \
>  	run-find-prologues.sh run-allregs.sh run-readelf-test1.sh \
> -	run-native-test.sh run-bug1-test.sh
> -#	dwfl-bug-addr-overflow
> +	run-native-test.sh run-bug1-test.sh \
> +	dwfl-bug-addr-overflow run-addrname-test.sh
>  # run-show-ciefde.sh
>  
>  if !STANDALONE

The newly enabled dwfl-bug-addr-overflow test doesn't compile for me with make check:

 make[5]: Entering directory `/home/mark/src/frysk-clean/frysk-clean-obj/frysk-imports/elfutils/tests'
 gcc -g -O2    ../../../../frysk/frysk-imports/elfutils/tests/dwfl-bug-addr-overflow.c   -o dwfl-bug-addr-overflow
 ../../../../frysk/frysk-imports/elfutils/tests/dwfl-bug-addr-overflow.c:26:20: error: config.h: No such file or directory
 ../../../../frysk/frysk-imports/elfutils/tests/dwfl-bug-addr-overflow.c:33:10: error: #include expects "FILENAME" or <FILENAME>

Also the run-elflint-test FAILs:

 section [22] '.dynamic': mandatory tag HASH not present
 section [22] '.dynamic': contains SYMTAB entry but not HASH
 FAIL: run-elflint-test.sh

Could you take a look?

Thanks,

Mark

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: frysk-imports/elfutils src/ranlib.c src/Change ...

[Nurdin Premji]

Mark Wielaard wrote:
>>  		  find-prologues funcretval allregs rdwrmmap 
>> -#		  dwfl-bug-addr-overflow
>> +		  dwfl-bug-addr-overflow arls
>>
>>     
> The newly enabled dwfl-bug-addr-overflow test doesn't compile for me with make check:
>
>  make[5]: Entering directory `/home/mark/src/frysk-clean/frysk-clean-obj/frysk-imports/elfutils/tests'
>  gcc -g -O2    ../../../../frysk/frysk-imports/elfutils/tests/dwfl-bug-addr-overflow.c   -o dwfl-bug-addr-overflow
>  ../../../../frysk/frysk-imports/elfutils/tests/dwfl-bug-addr-overflow.c:26:20: error: config.h: No such file or directory
>  ../../../../frysk/frysk-imports/elfutils/tests/dwfl-bug-addr-overflow.c:33:10: error: #include expects "FILENAME" or <FILENAME>
>
>   
Aha, missing an ending \ on the previous line. that got fixed.  Wonder 
why that didn't cause a bigger explosion with some random files hanging 
around in a Makefile. Oh well.
> Also the run-elflint-test FAILs:
>
>  section [22] '.dynamic': mandatory tag HASH not present
>  section [22] '.dynamic': contains SYMTAB entry but not HASH
>  FAIL: run-elflint-test.sh
>
> Could you take a look?
>   
I took a look at this, I'm not sure how to fix it so I just commented 
out the two tests that were added in version 0.126.
So make check should now pass again, at least on imports.