From: Andrew Cagney <cagney@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: frysk@sourceware.org
Subject: Re: frysk-imports/frysk/expunit ChangeLog Equals.j ...
Date: Tue, 06 Mar 2007 15:27:00 -0000 [thread overview]
Message-ID: <45ED8846.4080901@redhat.com> (raw)
In-Reply-To: <20070305135202.24295.qmail@sourceware.org>
Mark,
I don't follow these changes. If the code stripping of the matched text
was removed, then TestExpect and other code would start failing - was
this tested? And the grouping code is so that expect clients can access
the parts that were matched, that functionality was lost?
Andrew
mark@sourceware.org wrote:
> CVSROOT: /cvs/frysk
> Module name: frysk-imports
> Changes by: mark@sourceware.org 2007-03-05 13:52:02
>
> Modified files:
> frysk/expunit : ChangeLog Equals.java Expect.java Match.java
>
> Log message:
> * Expect.java (expectMilliseconds): Don't use unimplemented methods.
> * Match.java: Remove unimplemented group methods.
> * Equals.java: Likewise.
>
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/ChangeLog.diff?cvsroot=frysk&r1=1.8&r2=1.9
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/Equals.java.diff?cvsroot=frysk&r1=1.1&r2=1.2
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/Expect.java.diff?cvsroot=frysk&r1=1.8&r2=1.9
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/Match.java.diff?cvsroot=frysk&r1=1.1&r2=1.2
>
>
next parent reply other threads:[~2007-03-06 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070305135202.24295.qmail@sourceware.org>
2007-03-06 15:27 ` Andrew Cagney [this message]
2007-03-06 15:37 ` Mark Wielaard
2007-03-06 16:06 ` Andrew Cagney
2007-03-06 16:35 ` Mark Wielaard
2007-03-06 17:15 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ED8846.4080901@redhat.com \
--to=cagney@redhat.com \
--cc=frysk@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).