From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32225 invoked by alias); 6 Mar 2007 15:27:26 -0000 Received: (qmail 32217 invoked by uid 22791); 6 Mar 2007 15:27:25 -0000 X-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 06 Mar 2007 15:27:11 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l26FR2sn027981; Tue, 6 Mar 2007 10:27:02 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l26FR02h019006; Tue, 6 Mar 2007 10:27:00 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l26FQxsh002130; Tue, 6 Mar 2007 10:26:59 -0500 Message-ID: <45ED8846.4080901@redhat.com> Date: Tue, 06 Mar 2007 15:27:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.9 (X11/20070102) MIME-Version: 1.0 To: Mark Wielaard CC: frysk@sourceware.org Subject: Re: frysk-imports/frysk/expunit ChangeLog Equals.j ... References: <20070305135202.24295.qmail@sourceware.org> In-Reply-To: <20070305135202.24295.qmail@sourceware.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00176.txt.bz2 Mark, I don't follow these changes. If the code stripping of the matched text was removed, then TestExpect and other code would start failing - was this tested? And the grouping code is so that expect clients can access the parts that were matched, that functionality was lost? Andrew mark@sourceware.org wrote: > CVSROOT: /cvs/frysk > Module name: frysk-imports > Changes by: mark@sourceware.org 2007-03-05 13:52:02 > > Modified files: > frysk/expunit : ChangeLog Equals.java Expect.java Match.java > > Log message: > * Expect.java (expectMilliseconds): Don't use unimplemented methods. > * Match.java: Remove unimplemented group methods. > * Equals.java: Likewise. > > Patches: > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/ChangeLog.diff?cvsroot=frysk&r1=1.8&r2=1.9 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/Equals.java.diff?cvsroot=frysk&r1=1.1&r2=1.2 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/Expect.java.diff?cvsroot=frysk&r1=1.8&r2=1.9 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/frysk/expunit/Match.java.diff?cvsroot=frysk&r1=1.1&r2=1.2 > >