public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: frysk@sourceware.org
Subject: Re: frysk-imports/frysk/expunit ChangeLog Equals.j ...
Date: Tue, 06 Mar 2007 16:06:00 -0000	[thread overview]
Message-ID: <45ED9168.6060505@redhat.com> (raw)
In-Reply-To: <1173195413.4257.52.camel@dijkstra.wildebeest.org>

Mark,

I did a quick clean revert; methods such as group(...) were still 
missing :-(.

Can you post the warnings you're seeing so you/i can figure out what 
really should be changed?  If the warnings are significantly different 
then there's the complicating problem - for the moment only you will be 
seeing and fixing those problems.  In the short term, it may be prudent 
to scale back the warnings issued by the new compiler.

Andrew

Mark Wielaard wrote:
> On Tue, 2007-03-06 at 10:27 -0500, Andrew Cagney wrote:
>   
>> I don't follow these changes.  If the code stripping of the matched text 
>> was removed, then TestExpect and other code would start failing - was 
>> this tested?  And the grouping code is so that expect clients can access 
>> the parts that were matched, that functionality was lost?
>>     
>
> Yes this was a mistake. Fixed in the followup patch. The warnings that
> the new ecj gave had me confused. Sorry about that.
>
> Cheers,
>
> Mark
>
>   

  reply	other threads:[~2007-03-06 16:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070305135202.24295.qmail@sourceware.org>
2007-03-06 15:27 ` Andrew Cagney
2007-03-06 15:37   ` Mark Wielaard
2007-03-06 16:06     ` Andrew Cagney [this message]
2007-03-06 16:35       ` Mark Wielaard
2007-03-06 17:15         ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45ED9168.6060505@redhat.com \
    --to=cagney@redhat.com \
    --cc=frysk@sourceware.org \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).