From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16808 invoked by alias); 6 Mar 2007 17:15:42 -0000 Received: (qmail 16799 invoked by uid 22791); 6 Mar 2007 17:15:41 -0000 X-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SARE_LWSHORTT,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 06 Mar 2007 17:15:34 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l26HFOOK023816; Tue, 6 Mar 2007 12:15:27 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l26GkVCk020416; Tue, 6 Mar 2007 11:46:31 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l26GkTIw024631; Tue, 6 Mar 2007 11:46:30 -0500 Message-ID: <45ED9AE8.906@redhat.com> Date: Tue, 06 Mar 2007 17:15:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: Mark Wielaard CC: frysk@sourceware.org Subject: Re: frysk-imports/frysk/expunit ChangeLog Equals.j ... References: <20070305135202.24295.qmail@sourceware.org> <45ED8846.4080901@redhat.com> <1173195413.4257.52.camel@dijkstra.wildebeest.org> <45ED9168.6060505@redhat.com> <1173198912.4257.87.camel@dijkstra.wildebeest.org> In-Reply-To: <1173198912.4257.87.camel@dijkstra.wildebeest.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00182.txt.bz2 Hi Mark, Thanks for the additional background. That the group methods are not used is nothing less than a lack of test coverage - something that can be easily fixed. No matter what the style, trying to locally fix warnings about unused inerface method parameters is a loosing game. It is something better left to a code analysis tool that can see the entire code base and not just local interfaces and files. Andrew Mark Wielaard wrote: > Hi Andrew, > > On Tue, 2007-03-06 at 11:06 -0500, Andrew Cagney wrote: > >> I did a quick clean revert; methods such as group(...) were still >> missing :-(. >> > > Yes, I didn't put those back because I thought they weren't consistently > implemented (but see below). We could do with a little bit more API > review and documentation at times to prevent misinterpretation over > required functionality. > > >> Can you post the warnings you're seeing so you/i can figure out what >> really should be changed? If the warnings are significantly different >> then there's the complicating problem - for the moment only you will be >> seeing and fixing those problems. In the short term, it may be prudent >> to scale back the warnings issued by the new compiler. >> > > Yes, I just suggested the same in my Status mail. For now to build on > rawhide we should just use the disable-warnings patch that I attached to > this email: http://sourceware.org/ml/frysk/2007-q1/msg00173.html > And then we wait for this bug to get fixed (is already fixed upstream, > but needs a push into rawhide): > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231020 > before going over all the warning elimination again (and maybe select a > different set of warnings by default). > > The new warnings that ecj gives are for unused method parameters. That > reflects the design of that API though. ecj seems to prefer abstract > methods in base classes over stubbed default implementations. I do > actually agree with ecj in this case which is why I rewrote them that > way (and left the group methods out since they weren't actually used in > the code). So ecj can be used to enforce a particular API design style, > but to do that we probably need to have a discussion about the preferred > styles first. As soon as the above bug is fixed, new packages are in > rawhide and more people have had a chance to play with the new warning > settings we should go over them and make a selection of the defaults we > actually want. > > Cheers, > > Mark > >