Eclipse Formatting

Eclipse Formatting

[Mike Cvet]

2007-03-26  Nurdin Premji  <npremji@redhat.com>
          * .settings: Changed formatter to only use tabs and set tab 
size to 8.

Why did we do this? Now half of the code in the files I'm working on is 
pushed past column 80, and the other half is normal. Are we switching 
all the Java code to *another* default formatting now?

- Mike

Re: Eclipse Formatting

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

On Fri, 2007-03-30 at 08:11 -0400, Mike Cvet wrote:
> 2007-03-26  Nurdin Premji  <npremji@redhat.com>
>           * .settings: Changed formatter to only use tabs and set tab 
> size to 8.
> 
> Why did we do this? Now half of the code in the files I'm working on is 
> pushed past column 80, and the other half is normal. Are we switching 
> all the Java code to *another* default formatting now?

Isn't that the default GNU formatting style?
At least that is what I am using in emacs.
(But I agree that lines should not be > 80 chars.)

Cheers,

Mark

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Eclipse Formatting

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Fri, 2007-03-30 at 14:14 +0200, Mark Wielaard wrote:
> On Fri, 2007-03-30 at 08:11 -0400, Mike Cvet wrote:
> > 2007-03-26  Nurdin Premji  <npremji@redhat.com>
> >           * .settings: Changed formatter to only use tabs and set tab 
> > size to 8.
> > 
> > Why did we do this? Now half of the code in the files I'm working on is 
> > pushed past column 80, and the other half is normal. Are we switching 
> > all the Java code to *another* default formatting now?
> 
> Isn't that the default GNU formatting style?
> At least that is what I am using in emacs.
> (But I agree that lines should not be > 80 chars.)

Let me be a little bit more specific (since I am not actually using
eclipse and might misinterpret the actual change made to its formatter
*). I assume tabs != indentation, that indentation is 2 places and that
tabs should always be 8 everywhere.

Cheers,

Mark

*) For emacs I use the following hook in my .emacs:

(add-hook 'java-mode-hook
  (lambda ()
    (c-set-style "GNU")
    (c-set-offset 'inline-open 0)))


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Eclipse Formatting

[Mike Cvet]

Mark Wielaard wrote:
> On Fri, 2007-03-30 at 14:14 +0200, Mark Wielaard wrote:
>   
>> On Fri, 2007-03-30 at 08:11 -0400, Mike Cvet wrote:
>>     
>>> 2007-03-26  Nurdin Premji  <npremji@redhat.com>
>>>           * .settings: Changed formatter to only use tabs and set tab 
>>> size to 8.
>>>
>>> Why did we do this? Now half of the code in the files I'm working on is 
>>> pushed past column 80, and the other half is normal. Are we switching 
>>> all the Java code to *another* default formatting now?
>>>       
>> Isn't that the default GNU formatting style?
>> At least that is what I am using in emacs.
>> (But I agree that lines should not be > 80 chars.)
>>     
>
> Let me be a little bit more specific (since I am not actually using
> eclipse and might misinterpret the actual change made to its formatter
> *). I assume tabs != indentation, that indentation is 2 places and that
> tabs should always be 8 everywhere.
>
>   
Well unfortunately, *everything* is being pushed 8 spaces. =/

- Mike

Re: Eclipse Formatting

[Nurdin Premji]

Mike Cvet wrote:
> Mark Wielaard wrote:
>> On Fri, 2007-03-30 at 14:14 +0200, Mark Wielaard wrote:
>>  
>>> On Fri, 2007-03-30 at 08:11 -0400, Mike Cvet wrote:
>>>    
>>>> 2007-03-26  Nurdin Premji  <npremji@redhat.com>
>>>>           * .settings: Changed formatter to only use tabs and set 
>>>> tab size to 8.
>>>>
>>>> Why did we do this? Now half of the code in the files I'm working 
>>>> on is pushed past column 80, and the other half is normal. Are we 
>>>> switching all the Java code to *another* default formatting now?
>>>>       
>>> Isn't that the default GNU formatting style?
>>> At least that is what I am using in emacs.
>>> (But I agree that lines should not be > 80 chars.)
>>>     
>>
>> Let me be a little bit more specific (since I am not actually using
>> eclipse and might misinterpret the actual change made to its formatter
>> *). I assume tabs != indentation, that indentation is 2 places and that
>> tabs should always be 8 everywhere.
>>
>>   
> Well unfortunately, *everything* is being pushed 8 spaces. =/
>
> - Mike
My apologies, unless I am missing something with the eclipse formatter, 
it links tabs and indentation pretty tightly. I agree that this is a big 
pain.

Re: Eclipse Formatting

[Stan Cox]

This seems to mimic the emacs behavior:
 Project->Properties->Formatter->Edit->
 Tab Policy=Mixed 
 Indentation Size=2 
 Tab size=8

Re: Eclipse Formatting

[Sami Wagiaalla]

Stan Cox wrote:
> This seems to mimic the emacs behavior:
>  Project->Properties->Formatter->Edit->
>  Tab Policy=Mixed 
>  Indentation Size=2 
>  Tab size=8
>   

This is what I did and it is working fine for me.
If it is ok with everybody I will commit the settings file with my next 
patch.
In the future please discuss any changes to the formatter on this list 
before committing them.