From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29580 invoked by alias); 18 Apr 2007 17:40:32 -0000 Received: (qmail 29572 invoked by uid 22791); 18 Apr 2007 17:40:32 -0000 X-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_05,SPF_HELO_PASS,SPF_PASS,TW_GC X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 18 Apr 2007 18:40:30 +0100 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l3IHeQ9A021123 for ; Wed, 18 Apr 2007 13:40:26 -0400 Received: from lacrosse.corp.redhat.com (lacrosse.corp.redhat.com [172.16.52.154]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l3IHeOVg019699; Wed, 18 Apr 2007 13:40:24 -0400 Received: from [10.13.248.12] (vpn-248-12.boston.redhat.com [10.13.248.12]) by lacrosse.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id l3IHeNtq026526; Wed, 18 Apr 2007 13:40:23 -0400 Message-ID: <46265806.8030406@redhat.com> Date: Wed, 18 Apr 2007 18:13:00 -0000 From: Chris Moller User-Agent: Thunderbird 1.5.0.7 (X11/20060913) MIME-Version: 1.0 To: Phil Muldoon CC: Andrew Cagney , frysk Subject: Re: TestCase.fail() bug References: <4624FEE4.1070702@redhat.com> <46264878.7070002@redhat.com> <46265285.1020203@redhat.com> <46265439.1070706@redhat.com> In-Reply-To: <46265439.1070706@redhat.com> X-Enigmail-Version: 0.94.1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig89E0E3F52D4E7CA3B2395928" X-Virus-Checked: Checked by ClamAV on sourceware.org X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q2/txt/msg00076.txt.bz2 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig89E0E3F52D4E7CA3B2395928 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1648 Phil Muldoon wrote: > Chris Moller wrote: >> BTW, I've discovered, so far, about 50 hyper-pedantic-gcj "problems" in >> frysk. I've committed patches for some of them and am working on the >> rest. Some are /real/ brain-dead, like "if (1 =3D=3D 0) throw ....;" to= fix >> a problem where something was supposed to throw an exceeption but didn't >> have any code to do so. Unused parameters and redundant casts make up >> most of the problems. >>=20=20=20 > > > The declares a throw "Exception" but the code will never throw that > "Exception", ever is a new ECJ warning I think. In that case, I'd > delete the the Exception that was declared in the throw statement > itself instead of faking throwing it. It might unravel try/catches up > the code-line too, but those would be bugs as well. What I'm trying to achieve is to make exactly zero functional change to the way the code works. Some of the "bugs" are in places where the code is obviously incomplete (e.g., the unused parms in Match.java) and I don't want to screw up the work-in-progress of whoever is writing the code. In the missing throw case (in frysk-core/frysk/dom/DOMFactory.java) , I don't know if it's missing because it's not needed, or because the code isn't complete, and I don't want to have to deal with any possible repercussions (like gcj complaining that createDOM doesn't specify it throws NoDebugInfoException when that behaviour is expected elsewhere). I'm documenting all my hacks and I'll send the lot to debug-list when I'm done so you /real/ Java guys can, if you want to, go back and turn my hacks into something sensible. cm > > Regards > > Phil > --------------enig89E0E3F52D4E7CA3B2395928 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 251 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFGJlgGmpMCeQnqFMkRAgM3AJ9FjpOatf3dF8F16wKIiRy9aGPf9QCdHQa1 i+V+E0qgSulO3f1ZXL0QKkM= =II5/ -----END PGP SIGNATURE----- --------------enig89E0E3F52D4E7CA3B2395928--