public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: Frysk Hackers <frysk@sourceware.org>
Subject: Re: Outline Proposal: add getMaps() to abstract Proc.java
Date: Tue, 15 May 2007 21:12:00 -0000	[thread overview]
Message-ID: <4648C90E.6080909@redhat.com> (raw)
In-Reply-To: <46489E18.6000907@redhat.com>

Phil,

Like the idea.  While the purest might suggest that for every field 
there should be a getter, I've found that having the fields "public 
final" is more pragmatic.

Andrew

Phil Muldoon wrote:
> Phil Muldoon wrote:
>
> In addition, I just realized that we might as well give the name of 
> the map while "we are there", otherwise the user will just have to go 
> to the same spot to find it. So add a String name; to the data of the 
> maps class.
>
>>
>>
>> in Maps.java
>>
>> // Think of a different name for this class
>> public class Map
>> {
>>    public long addressLow;
>>    public long addressHigh;
>>    public boolean permRead;
>>    public boolean permWrite;
>>    public boolean permExecute;
>>    public boolean shared;
>>    public long offset;
>>    public int devMajor;
>>    public int devMinor;
>>    public int inode;       public int pathnameOffset;
>>    public int pathnameLength;
>>
>>    public void Map(....)
>>    {
>>       // implement constructor setters here
>>        ............
>>        ............
>>    }
>> }
>>
>>
>>
>

      reply	other threads:[~2007-05-14 20:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-14 17:36 Phil Muldoon
2007-05-14 18:01 ` Phil Muldoon
2007-05-15 21:12   ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4648C90E.6080909@redhat.com \
    --to=cagney@redhat.com \
    --cc=frysk@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).