From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20275 invoked by alias); 28 May 2007 19:35:37 -0000 Received: (qmail 20267 invoked by uid 22791); 28 May 2007 19:35:36 -0000 X-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS,TW_DW X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 May 2007 19:35:31 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l4SJZTQb010730 for ; Mon, 28 May 2007 15:35:29 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l4SJZSqo031487 for ; Mon, 28 May 2007 15:35:29 -0400 Received: from [172.16.14.160] (tow.toronto.redhat.com [172.16.14.160]) by pobox.toronto.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l4SJZSpu022995; Mon, 28 May 2007 15:35:28 -0400 Message-ID: <465B2EFE.40108@redhat.com> Date: Mon, 28 May 2007 20:15:00 -0000 From: Nurdin User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Nurdin CC: Frysk List Subject: Re: Dwfl callbacks to use frysk to get memory. References: <465AF7CF.6010302@redhat.com> In-Reply-To: <465AF7CF.6010302@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q2/txt/msg00212.txt.bz2 Nurdin wrote: > All the code to get elfutils to use frysk to access memory is located > in the latest patch applied to bugzilla 4513. > > > I have created a method Proc.getDwfl() but I am unsure as to where > this dwfl should actually be created. (I stuck it in proc since that > had all the necessary data to create a Dwfl, it could easily take a > proc as a parameter and be located anywhere in the core.) > > Any suggestions? Should getDwfl() stay in Proc or be moved elsewhere? As discussed on irc, it was decided the best place for this would be in a factory, hence frysk.debuginfo.DwflFactory was created and committed. The Dwfl objects created by this factory use frysk to read the process's memory.