From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6787 invoked by alias); 1 Jun 2007 15:51:52 -0000 Received: (qmail 6666 invoked by uid 22791); 1 Jun 2007 15:51:51 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 01 Jun 2007 15:51:49 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l51Fpjcx005817 for ; Fri, 1 Jun 2007 11:51:45 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l51Fpiul022464 for ; Fri, 1 Jun 2007 11:51:45 -0400 Received: from [10.11.14.72] (vpn-14-72.rdu.redhat.com [10.11.14.72]) by pobox.toronto.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l51Fpe02007571; Fri, 1 Jun 2007 11:51:40 -0400 Message-ID: <4660408B.9060809@redhat.com> Date: Fri, 01 Jun 2007 16:17:00 -0000 From: Adam Jocksch User-Agent: Thunderbird 1.5.0.10 (X11/20070403) MIME-Version: 1.0 To: Sami Wagiaalla CC: frysk Subject: Re: ValueFactory References: <46603AE0.2020201@redhat.com> In-Reply-To: <46603AE0.2020201@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q2/txt/msg00230.txt.bz2 Sami Wagiaalla wrote: > Okay so here is a skeleton: > > // this takes care of the creation of Value object > public class ValueFactory{ > > public static ValueFactory getFactory(Proc){ > // check cache and return a ValueFactory > } > private ValueFactory(Proc proc){ > } > > public Value getValue(String name, Frame currentFrame){ > ... > } > > public Value getValue(DwarfDie die){ > ... } > > } > > // this is just speculation but can be put either in Value it self or > in a ValuePrint object > ... > public String printValue(Value value){ > } > ... > > How well will the above work for hpd, stack examination, source > window, DisplayVariable, an any other interested parties :) > > Sami That looks usable from my perspective, although I'm probably not in the best position to comment on plausability issues :) Adam