* ValueFactory
@ 2007-06-01 15:51 Sami Wagiaalla
2007-06-01 16:17 ` ValueFactory Adam Jocksch
2007-06-01 19:05 ` ValueFactory Andrew Cagney
0 siblings, 2 replies; 3+ messages in thread
From: Sami Wagiaalla @ 2007-06-01 15:51 UTC (permalink / raw)
To: frysk
Okay so here is a skeleton:
// this takes care of the creation of Value object
public class ValueFactory{
public static ValueFactory getFactory(Proc){
// check cache and return a ValueFactory
}
private ValueFactory(Proc proc){
}
public Value getValue(String name, Frame currentFrame){
...
}
public Value getValue(DwarfDie die){
...
}
}
// this is just speculation but can be put either in Value it self or in
a ValuePrint object
...
public String printValue(Value value){
}
...
How well will the above work for hpd, stack examination, source window,
DisplayVariable, an any other interested parties :)
Sami
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: ValueFactory
2007-06-01 15:51 ValueFactory Sami Wagiaalla
@ 2007-06-01 16:17 ` Adam Jocksch
2007-06-01 19:05 ` ValueFactory Andrew Cagney
1 sibling, 0 replies; 3+ messages in thread
From: Adam Jocksch @ 2007-06-01 16:17 UTC (permalink / raw)
To: Sami Wagiaalla; +Cc: frysk
Sami Wagiaalla wrote:
> Okay so here is a skeleton:
>
> // this takes care of the creation of Value object
> public class ValueFactory{
>
> public static ValueFactory getFactory(Proc){
> // check cache and return a ValueFactory
> }
> private ValueFactory(Proc proc){
> }
>
> public Value getValue(String name, Frame currentFrame){
> ...
> }
>
> public Value getValue(DwarfDie die){
> ... }
>
> }
>
> // this is just speculation but can be put either in Value it self or
> in a ValuePrint object
> ...
> public String printValue(Value value){
> }
> ...
>
> How well will the above work for hpd, stack examination, source
> window, DisplayVariable, an any other interested parties :)
>
> Sami
That looks usable from my perspective, although I'm probably not in the
best position to comment on plausability issues :)
Adam
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: ValueFactory
2007-06-01 15:51 ValueFactory Sami Wagiaalla
2007-06-01 16:17 ` ValueFactory Adam Jocksch
@ 2007-06-01 19:05 ` Andrew Cagney
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cagney @ 2007-06-01 19:05 UTC (permalink / raw)
To: Sami Wagiaalla; +Cc: frysk
With the below, a typical use will be:
ValueFactory.getFactory(frame.task.proc).getValue ("a+2", frame)
so short circuit that vis:
ValueFactory
static ValueFactory getFactory(Frame)
Value getValue ("string");
... same for die ...
Andrew
Sami Wagiaalla wrote:
> Okay so here is a skeleton:
>
> // this takes care of the creation of Value object
> public class ValueFactory{
>
> public static ValueFactory getFactory(Proc){
> // check cache and return a ValueFactory
> }
> private ValueFactory(Proc proc){
> }
>
> public Value getValue(String name, Frame currentFrame){
> ...
> }
>
> public Value getValue(DwarfDie die){
> ... }
>
> }
>
> // this is just speculation but can be put either in Value it self or
> in a ValuePrint object
> ...
> public String printValue(Value value){
> }
> ...
>
> How well will the above work for hpd, stack examination, source
> window, DisplayVariable, an any other interested parties :)
>
> Sami
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-06-01 16:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-01 15:51 ValueFactory Sami Wagiaalla
2007-06-01 16:17 ` ValueFactory Adam Jocksch
2007-06-01 19:05 ` ValueFactory Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).