* Patch - fix ppc64 build
@ 2007-06-12 22:16 Carlos Eduardo Seo
2007-06-14 15:56 ` Andrew Cagney
0 siblings, 1 reply; 2+ messages in thread
From: Carlos Eduardo Seo @ 2007-06-12 22:16 UTC (permalink / raw)
To: Frysk Mailing List
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi folks!
The attached patch fixes a wrong dependency while building for ppc64. It
removes the need of libunwind-i386/src/.libs/libunwind-x86.a for a ppc
build.
Can be used together with Jose Flavio's patch for libunwind:
http://sources.redhat.com/ml/frysk/2007-q2/msg00174.html
I hope it helps people who are trying to build Frysk on ppc64.
Regards,
- --
Carlos Eduardo Seo
Linux on Power Software Engineer
IBM Linux Technology Center Brazil
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGbxZlqvq7Aov/qQARAh+iAJ4pkAANOlSRnRT6Ehr8iLvEziumywCfQHVG
uJbh0QT/zWplx3/izpyL9C0=
=1vcR
-----END PGP SIGNATURE-----
[-- Attachment #2: ppc-build.patch --]
[-- Type: text/plain, Size: 4563 bytes --]
Index: frysk/frysk-core/Makefile.am
===================================================================
--- frysk.orig/frysk-core/Makefile.am
+++ frysk/frysk-core/Makefile.am
@@ -75,11 +75,16 @@ GEN_GCJ_LDADD += ../frysk-imports/elfuti
GEN_GCJ_LDADD += ../frysk-imports/elfutils/libdw/libdw.a
GEN_GCJ_LDADD += ../frysk-imports/elfutils/libebl/libebl.a
GEN_GCJ_LDADD += ../frysk-imports/elfutils/libelf/libelf.a
+
if USE_LIBUNWIND
-GEN_GCJ_LDADD += ../frysk-imports/libunwind/src/.libs/libunwind-ptrace.a \
- ../frysk-imports/libunwind/src/.libs/libunwind-$(libunwind_cpu).a \
- ../frysk-imports/libunwind-i386/src/.libs/libunwind-x86.a
+ GEN_GCJ_LDADD += ../frysk-imports/libunwind/src/.libs/libunwind-ptrace.a \
+ ../frysk-imports/libunwind/src/.libs/libunwind-$(libunwind_cpu).a
+endif
+
+if ARCH_x86
+ GEN_GCJ_LDADD += ../frysk-imports/libunwind-i386/src/.libs/libunwind-x86.a
endif
+
GEN_GCJ_LDADD += -lstdc++
# Stub bfd_getb32 and bfd_getl32 for PPC64. Unconditionally
# link -lbfd_get just for simplification.
Index: frysk/frysk-core/common/m4/frysk-use-libunwind.m4
===================================================================
--- frysk.orig/frysk-core/common/m4/frysk-use-libunwind.m4
+++ frysk/frysk-core/common/m4/frysk-use-libunwind.m4
@@ -51,4 +51,5 @@ i?86) AC_SUBST([libunwind_cpu], [x86]);;
powerpc64) AC_SUBST([libunwind_cpu], [ppc64]);;
*) AC_SUBST([libunwind_cpu], [$target_cpu]);;
esac
+AM_CONDITIONAL([ARCH_x86], [test $target_cpu = i?86])
])
Index: frysk/frysk-gtk/Makefile.am
===================================================================
--- frysk.orig/frysk-gtk/Makefile.am
+++ frysk/frysk-gtk/Makefile.am
@@ -59,11 +59,16 @@ GEN_GCJ_LDADD += ../frysk-imports/elfuti
GEN_GCJ_LDADD += ../frysk-imports/elfutils/libdw/libdw.a
GEN_GCJ_LDADD += ../frysk-imports/elfutils/libebl/libebl.a
GEN_GCJ_LDADD += ../frysk-imports/elfutils/libelf/libelf.a
+
if USE_LIBUNWIND
-GEN_GCJ_LDADD += ../frysk-imports/libunwind/src/.libs/libunwind-ptrace.a \
- ../frysk-imports/libunwind/src/.libs/libunwind-$(libunwind_cpu).a \
- ../frysk-imports/libunwind-i386/src/.libs/libunwind-x86.a
+ GEN_GCJ_LDADD += ../frysk-imports/libunwind/src/.libs/libunwind-ptrace.a \
+ ../frysk-imports/libunwind/src/.libs/libunwind-$(libunwind_cpu).a
+endif
+
+if ARCH_x86
+ GEN_GCJ_LDADD += ../frysk-imports/libunwind-i386/src/.libs/libunwind-x86.a
endif
+
GEN_GCJ_LDADD += -lstdc++
# Stub bfd_getb32 and bfd_getl32 for PPC64. Unconditionally
# link -lbfd_get just for simplification.
Index: frysk/frysk-gtk/common/m4/frysk-use-libunwind.m4
===================================================================
--- frysk.orig/frysk-gtk/common/m4/frysk-use-libunwind.m4
+++ frysk/frysk-gtk/common/m4/frysk-use-libunwind.m4
@@ -51,4 +51,5 @@ i?86) AC_SUBST([libunwind_cpu], [x86]);;
powerpc64) AC_SUBST([libunwind_cpu], [ppc64]);;
*) AC_SUBST([libunwind_cpu], [$target_cpu]);;
esac
+AM_CONDITIONAL([ARCH_x86], [test $target_cpu = i?86])
])
Index: frysk/frysk-gui/Makefile.am
===================================================================
--- frysk.orig/frysk-gui/Makefile.am
+++ frysk/frysk-gui/Makefile.am
@@ -74,11 +74,16 @@ GEN_GCJ_LDADD += ../frysk-imports/elfuti
GEN_GCJ_LDADD += ../frysk-imports/elfutils/libdw/libdw.a
GEN_GCJ_LDADD += ../frysk-imports/elfutils/libebl/libebl.a
GEN_GCJ_LDADD += ../frysk-imports/elfutils/libelf/libelf.a
+
if USE_LIBUNWIND
-GEN_GCJ_LDADD += ../frysk-imports/libunwind/src/.libs/libunwind-ptrace.a \
- ../frysk-imports/libunwind/src/.libs/libunwind-$(libunwind_cpu).a \
- ../frysk-imports/libunwind-i386/src/.libs/libunwind-x86.a
+ GEN_GCJ_LDADD += ../frysk-imports/libunwind/src/.libs/libunwind-ptrace.a \
+ ../frysk-imports/libunwind/src/.libs/libunwind-$(libunwind_cpu).a
+endif
+
+if ARCH_x86
+ GEN_GCJ_LDADD += ../frysk-imports/libunwind-i386/src/.libs/libunwind-x86.a
endif
+
GEN_GCJ_LDADD += -lstdc++
GEN_GCJ_LDADD += ../frysk-gtk/libfrysk-ftk.a
GEN_GCJ_LDADD += -L../frysk-gtk/EggTrayIcon
Index: frysk/frysk-gui/common/m4/frysk-use-libunwind.m4
===================================================================
--- frysk.orig/frysk-gui/common/m4/frysk-use-libunwind.m4
+++ frysk/frysk-gui/common/m4/frysk-use-libunwind.m4
@@ -51,4 +51,5 @@ i?86) AC_SUBST([libunwind_cpu], [x86]);;
powerpc64) AC_SUBST([libunwind_cpu], [ppc64]);;
*) AC_SUBST([libunwind_cpu], [$target_cpu]);;
esac
+AM_CONDITIONAL([ARCH_x86], [test $target_cpu = i?86])
])
[-- Attachment #3: ppc-build.patch.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Patch - fix ppc64 build
2007-06-12 22:16 Patch - fix ppc64 build Carlos Eduardo Seo
@ 2007-06-14 15:56 ` Andrew Cagney
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cagney @ 2007-06-14 15:56 UTC (permalink / raw)
To: Carlos Eduardo Seo; +Cc: Frysk Mailing List
Carlos Eduardo Seo wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi folks!
>
> The attached patch fixes a wrong dependency while building for ppc64. It
> removes the need of libunwind-i386/src/.libs/libunwind-x86.a for a ppc
> build.
>
>
Hi Carlos,
Nurdin and I have been discussing this on IRC. We're going to clean up
the build so that, instead of both "native":
-GEN_GCJ_LDADD += ../frysk-imports/libunwind/src/.libs/libunwind-ptrace.a \
- ../frysk-imports/libunwind/src/.libs/libunwind-$(libunwind_cpu).a \
and "remote":
- ../frysk-imports/libunwind-i386/src/.libs/libunwind-x86.a
libraries, just the remote libraries will be built - that is all frysk
needslibrariesi.e., a mix of "native" and "remote" (works on core files)
code, just the remote unwinders will be, and always built.
That would mean that for the PowerPC you'll want to add 32- and 64- bit
builds of libunwind to the build system, adding support for those
architectures.
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-14 15:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-12 22:16 Patch - fix ppc64 build Carlos Eduardo Seo
2007-06-14 15:56 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).