From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9787 invoked by alias); 10 Jul 2007 17:03:10 -0000 Received: (qmail 9780 invoked by uid 22791); 10 Jul 2007 17:03:09 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Jul 2007 17:03:06 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l6AH33fQ000456; Tue, 10 Jul 2007 13:03:03 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l6AH32kP022542; Tue, 10 Jul 2007 13:03:02 -0400 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l6AH31Mk006958; Tue, 10 Jul 2007 13:03:01 -0400 Message-ID: <4693BBD6.904@redhat.com> Date: Tue, 10 Jul 2007 17:03:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Chris Moller CC: Mark Wielaard , frysk@sourceware.org Subject: Re: [patch] Breakpoint - only reset instruction bytes covered by breakpoint instruction bytes References: <1183969101.3654.5.camel@dijkstra.wildebeest.org> <46923B73.4050000@redhat.com> <1184058613.3607.10.camel@dijkstra.wildebeest.org> <4693A9E3.1040008@redhat.com> <4693B4C5.4050001@redhat.com> In-Reply-To: <4693B4C5.4050001@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00070.txt.bz2 Chris Moller wrote: > Andrew Cagney wrote: > >> Mark Wielaard wrote: >> >>> On Mon, 2007-07-09 at 09:43 -0400, Andrew Cagney wrote: >>> >>> >>>> Please use the ByteBuffer's bulk get/put methods. >>>> >>>> >>> >>> >> Interesting slip-up, fortunately you've got peek and peekFully method >> ready to wrap? As for micro-optimizing the PtraceByteBuffer, that is >> something we can pick up when there's evidence supporting the need. >> >> >>> Nice idea! But there is no bulk put method in ByteBuffer >>> > > It is! So just a few dots need to be connected. > I'm not entirely sure it's what you guys are talking about, but > frysk-imports/frysk/sys/cni/StatelessFile.cxx supports a pwrite() that's > analogous to the bulk pread(), but it was never incorporated into > MemorySpaceByteBuffer because no one seemed interested. > > >>> (there is a >>> bulk get(), but there are no single byte get() loops in the current >>> code). It would be nice to have a bulk put() method to optimize things, >>> so I filed bug http://sourceware.org/bugzilla/show_bug.cgi?id=4760 >>> >>> Cheers, >>> >>> Mark >>> >>> > >