From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29551 invoked by alias); 30 Jul 2007 17:44:57 -0000 Received: (qmail 29544 invoked by uid 22791); 30 Jul 2007 17:44:56 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 30 Jul 2007 17:44:50 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l6UHikoj027073; Mon, 30 Jul 2007 13:44:46 -0400 Received: from pobox.hsv.redhat.com (pobox.hsv.redhat.com [172.16.16.12]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l6UHijVp026858; Mon, 30 Jul 2007 13:44:46 -0400 Received: from localhost.localdomain (vpn-14-32.rdu.redhat.com [10.11.14.32]) by pobox.hsv.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l6UHii9g004020; Mon, 30 Jul 2007 13:44:45 -0400 Message-ID: <46AE238B.5020204@redhat.com> Date: Mon, 30 Jul 2007 17:44:00 -0000 From: Phil Muldoon User-Agent: Thunderbird 2.0.0.5 (X11/20070719) MIME-Version: 1.0 To: Mark Wielaard CC: frysk@sourceware.org Subject: Re: Make CoredumpAction use Task.getRegisterBanks() References: <1185814384.3674.36.camel@dijkstra.wildebeest.org> In-Reply-To: <1185814384.3674.36.camel@dijkstra.wildebeest.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00227.txt.bz2 Mark Wielaard wrote: > Hi, > > Phil and me were discussing cleaning up some of the > Memory/RegisterBuffers between ptrace and core proc Tasks on irc and > noticed that CoredumpAction was accessing the RegisterBanks directly > through the Isa. To make splitting the issue of getting the > RegisterBanks (Task specific) and doing the Register name mapping to > bank number and offset (Isa specific) easier we wanted to make all code > go through Task.getRegisterBanks(). This patch does that for > CoredumpAction: > Looks good. The only function here is to attain the raw memory behind the byte buffers for floating point registers, as that is dumped whole into the FP Register Note. CoredumpAction has been gutted locally and being refactored into a Corefile{arch}factory. I'll take your patch and reconstitute it there Many Thanks Phil