From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25261 invoked by alias); 31 Jul 2007 23:34:18 -0000 Received: (qmail 25252 invoked by uid 22791); 31 Jul 2007 23:34:17 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 31 Jul 2007 23:34:12 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l6VNYAnt015567 for ; Tue, 31 Jul 2007 19:34:10 -0400 Received: from pobox.hsv.redhat.com (pobox.hsv.redhat.com [172.16.16.12]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l6VNY99M020462 for ; Tue, 31 Jul 2007 19:34:10 -0400 Received: from localhost.localdomain (vpn-14-28.rdu.redhat.com [10.11.14.28]) by pobox.hsv.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l6VNY8Oi017150 for ; Tue, 31 Jul 2007 19:34:09 -0400 Message-ID: <46AFC6F0.2030606@redhat.com> Date: Tue, 31 Jul 2007 23:34:00 -0000 From: Phil Muldoon User-Agent: Thunderbird 2.0.0.5 (X11/20070719) MIME-Version: 1.0 To: frysk@sourceware.org Subject: Re: frysk-core/frysk/util ChangeLog CoredumpAction ... References: <20070731232332.21734.qmail@sourceware.org> In-Reply-To: <20070731232332.21734.qmail@sourceware.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00251.txt.bz2 Awhile back, when we were first working on fcore, Yong Zheng from IBM came up with the idea what we make a factory for the note segments and other various architecture specific sections. This would allow us to separate the architecture specific sections into their own classes. For reasons I cannot remember, we did not move that way and continued using one class. I've not heard from Yong in awhile, but credit where credit is due for the original idea. I re-factored these classes last week, created the factory and client classes and tested them on x86 and x86_64. If someone has PPC32 and PPC64 hardware, please let me know the results. I'm not sure all these client classes belong in the util/ namespace, and will likely be moved somewhere more appropriate in the future. This, and the re-factor, is part one of the CoredumpAction improvements. Now the code is cleaner, the next step it to move towards a streaming model for segments Regards Phil pmuldoon@sourceware.org wrote: > CVSROOT: /cvs/frysk > Module name: frysk-core > Changes by: pmuldoon@sourceware.org 2007-07-31 23:23:32 > > Modified files: > frysk/util : ChangeLog CoredumpAction.java > Added files: > frysk/util : LinuxElfCorefile.java > LinuxElfCorefileFactory.java > LinuxElfCorefilePPC32.java > LinuxElfCorefilePPC32on64.java > LinuxElfCorefilePPC64.java > LinuxElfCorefilex86.java > LinuxElfCorefilex8664.java > > Log message: > 2007-07-31 Phil Muldoon > > * CoredumpAction.java: Rewritten and Refactored to > LinuxElfCorefile.java. > * LinuxElfCorefileFactory.java: New. Return correct core > file back-end. > * LinuxCoreFile.java: New file. > * LinuxCoreFilex86.java: New file. > * LinuxCoreFilex8664.java: New file. > * LinuxCoreFilePPC32.java: New file. > * LinuxCoreFilePPC32On64.java: New file. > * LinuxCoreFilePPC64.java: New file. > > Patches: > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefile.java.diff?cvsroot=frysk&r1=NONE&r2=1.1 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefileFactory.java.diff?cvsroot=frysk&r1=NONE&r2=1.1 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilePPC32.java.diff?cvsroot=frysk&r1=NONE&r2=1.1 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilePPC32on64.java.diff?cvsroot=frysk&r1=NONE&r2=1.1 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilePPC64.java.diff?cvsroot=frysk&r1=NONE&r2=1.1 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilex86.java.diff?cvsroot=frysk&r1=NONE&r2=1.1 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilex8664.java.diff?cvsroot=frysk&r1=NONE&r2=1.1 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/ChangeLog.diff?cvsroot=frysk&r1=1.154&r2=1.155 > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/CoredumpAction.java.diff?cvsroot=frysk&r1=1.18&r2=1.19 > >