From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2906 invoked by alias); 2 Aug 2007 02:58:49 -0000 Received: (qmail 2894 invoked by uid 22791); 2 Aug 2007 02:58:47 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 02 Aug 2007 02:58:43 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l722weE0006787 for ; Wed, 1 Aug 2007 22:58:40 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l722weUG001501 for ; Wed, 1 Aug 2007 22:58:40 -0400 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l722wcSO021117; Wed, 1 Aug 2007 22:58:39 -0400 Message-ID: <46B14863.60601@redhat.com> Date: Thu, 02 Aug 2007 02:58:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Mark Wielaard CC: frysk@sourceware.org Subject: putting Ptrace back to 64-bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00256.txt.bz2 Mark, I don't understand the rationale behind this change: 2007-07-30 Mark Wielaard * FileDescriptor.java (read): Make start and length ints. (write): Likewise. * Ptrace.java (peek): Make length and offset ints. * StatelessFile.java (pread): Make start and length ints. (pwrite): Likewise. * TestFileDescriptor.java (IO.op): Likewise. (assertArrayIndexOutOfBounds): Likewise. (testReadOutOfBounds): Likewise. (testWriteOutOfBounds): Likewise. * TestPtrace.java (verifyOutOfBounds): Make length and offset ints. * TestStatelessFile.java: Make start and length ints. * cni/Errno.cxx (verifyBounds): Make start and length ints. * cni/Errno.hxx: Likewise. * cni/FileDescriptor.cxx (read): Make start and length jints. (write): Likewise. * cni/Ptrace.cxx (peek): Make length and offset jints. * cni/StatelessFile.cxx (pread): Make start and length jints. (pwrite): Likewise. It forces calling code to contend with Java's bone-head "int" is 32-bits and be damed. Having all of these "long", which I only just went through and cleaned up, avoided all that. The only thing missing was for inua to be matched to this style. Andrew