From: Phil Muldoon <pmuldoon@redhat.com>
To: frysk@sourceware.org, Tim Moore <timoore@redhat.com>
Subject: Re: frysk-core/frysk hpd/AllPTSet.java hpd/CLI.jav ...
Date: Fri, 10 Aug 2007 01:49:00 -0000 [thread overview]
Message-ID: <46BBC434.3080708@redhat.com> (raw)
In-Reply-To: <46BBAB69.8050008@redhat.com>
Think I fixed it. The below patch returns the correct ArrayList iterator
in StaticPTSet. Tasks are now returned over TaskData.
Index: StaticPTSet.java
===================================================================
RCS file: /cvs/frysk/frysk-core/frysk/hpd/StaticPTSet.java,v
retrieving revision 1.1
diff -u -p -r1.1 StaticPTSet.java
--- StaticPTSet.java 25 Jul 2007 00:37:25 -0000 1.1
+++ StaticPTSet.java 10 Aug 2007 01:48:05 -0000
@@ -98,7 +98,7 @@ class StaticPTSet implements PTSet
result.add( ((TaskData)
temp.get(j)).getTask() );
}
- return temp.iterator();
+ return result.iterator();
}
public Iterator getTaskData()
Phil Muldoon wrote:
> I did a simple adjustment here
>
> [pmuldoon@localhost hpd]$ cvs diff WhereCommand.java
> Index: WhereCommand.java
> ===================================================================
> RCS file: /cvs/frysk/frysk-core/frysk/hpd/WhereCommand.java,v
> retrieving revision 1.4
> diff -u -p -r1.4 WhereCommand.java
> --- WhereCommand.java 9 Aug 2007 17:13:49 -0000 1.4
> +++ WhereCommand.java 9 Aug 2007 23:50:07 -0000
> @@ -69,7 +69,7 @@ class WhereCommand
> level = Integer.parseInt((String)params.get(0));
> Iterator taskIter = ptset.getTasks();
> while (taskIter.hasNext()) {
> - Task task = (Task)taskIter.next();
> + Task task = ((TaskData)taskIter.next()).getTask();
> DebugInfoFrame tmpFrame = null;
> int l = cli.getTaskStackLevel(task);
> int stopLevel;
>
> And that makes it work for corefile tasks, but fail for live tasks
> with the exception:
>
> [pmuldoon@localhost bindir]$ ./fhpd 15630
> Attached to process 15630
> (fhpd) where
> Inside where command
> java.lang.ClassCastException: frysk.proc.live.LinuxTask cannot be cast
> to frysk.hpd.TaskData
> at frysk.hpd.WhereCommand.handle(WhereCommand.java:74)
> at frysk.hpd.CLI.execCommand(CLI.java:436)
> at frysk.bindir.fhpd.main(fhpd.java:148)
> Internal debugger error: frysk.proc.live.LinuxTask cannot be cast to
> frysk.hpd.TaskData
>
>
> Could be a case of weak typing? Plugged green wire into red jack and
> all that ;)
>
>
> Regards
>
> Phil
>
> Phil Muldoon wrote:
>> Tim
>>
>> At first glance, and I could be wrong, but this commit appears to have
>> broken all core file operations in fhpd.
>>
>> [pmuldoon@localhost bindir]$ ./fhpd core.3260 /bin/bash
>> Attached to core file:
>> /home/pmuldoon/frysk_bin/frysk-core/frysk/bindir/core.3260
>> (fhpd) where
>> java.lang.ClassCastException: frysk.hpd.TaskData cannot be cast to
>> frysk.proc.Task
>
>> at frysk.hpd.WhereCommand.handle(WhereCommand.java:72)
>> at frysk.hpd.CLI.execCommand(CLI.java:436)
>> at frysk.bindir.fhpd.main(fhpd.java:148)
>> Internal debugger error: frysk.hpd.TaskData cannot be cast to
>> frysk.proc.Task
>> (fhpd) quit
>> java.lang.ClassCastException: frysk.hpd.TaskData cannot be cast to
>> frysk.proc.Task
>> at frysk.hpd.DetachCommand.handle(DetachCommand.java:68)
>> at frysk.hpd.QuitCommand.handle(QuitCommand.java:67)
>> at frysk.hpd.CLI.execCommand(CLI.java:436)
>> at frysk.bindir.fhpd.main(fhpd.java:148)
>> Quitting...
>> Internal debugger error: frysk.hpd.TaskData cannot be cast to
>> frysk.proc.Task
>>
>>
>> moore@sourceware.org wrote:
>>> CVSROOT: /cvs/frysk
>>> Module name: frysk-core
>>> Changes by: moore@sourceware.org 2007-08-09 17:06:56
>>>
>>> Modified files:
>>> frysk/hpd : AllPTSet.java CLI.java ChangeLog
>>> frysk/rt : ChangeLog Added files:
>>> frysk/rt : ProcTaskIDManager.java Removed files:
>>> frysk/hpd : TestSetCreation.java
>>> Log message:
>>> Infrastructure for ptsets based on real processes and tasks
>>> frysk-core/frysk/hpd/ChangeLog
>>> 2007-08-08 Tim Moore <timoore@redhat.com>
>>> * AllPTSet.java: Complete rewrite to reference active Procs and
>>> Tasks via the ProcTaskIDManager.
>>> * CLI.java (idManager): New variable, reference to
>>> ProcTaskIDManager.
>>> (startAttach): Only initialize steppingEngine once.
>>> (CLI): Initialize idManager.
>>> (getCommandPTSet): New method.
>>> * TestSetCreation.java: Remove file because AllPTSet doesn't
>>> support creation of random proc/task numbers anymore.
>>> frysk-core/frysk/rt/ChangeLog
>>> 2007-08-08 Tim Moore <timoore@redhat.com>
>>> * ProcTaskIDManager.java: New file.
>>>
>>> Patches:
>>> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/hpd/AllPTSet.java.diff?cvsroot=frysk&r1=1.1&r2=1.2
>>>
>>> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/hpd/CLI.java.diff?cvsroot=frysk&r1=1.7&r2=1.8
>>>
>>> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/hpd/ChangeLog.diff?cvsroot=frysk&r1=1.27&r2=1.28
>>>
>>> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/hpd/TestSetCreation.java.diff?cvsroot=frysk&r1=1.1&r2=NONE
>>>
>>> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/rt/ProcTaskIDManager.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
>>>
>>> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/rt/ChangeLog.diff?cvsroot=frysk&r1=1.352&r2=1.353
>>>
>>>
>>>
>>
>>
>
prev parent reply other threads:[~2007-08-10 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070809170656.7895.qmail@sourceware.org>
2007-08-09 23:10 ` Phil Muldoon
2007-08-10 0:04 ` Phil Muldoon
2007-08-10 1:49 ` Phil Muldoon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BBC434.3080708@redhat.com \
--to=pmuldoon@redhat.com \
--cc=frysk@sourceware.org \
--cc=timoore@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).