From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <frysk-return-2259-listarch-frysk=sources.redhat.com@sourceware.org>
Received: (qmail 27737 invoked by alias); 14 Aug 2007 16:41:06 -0000
Received: (qmail 27560 invoked by uid 22791); 14 Aug 2007 16:41:05 -0000
X-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 14 Aug 2007 16:41:00 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l7EGewOO017395 	for <frysk@sourceware.org>; Tue, 14 Aug 2007 12:40:58 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l7EGevvI031451 	for <frysk@sourceware.org>; Tue, 14 Aug 2007 12:40:57 -0400
Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) 	by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l7EGevaU000618 	for <frysk@sourceware.org>; Tue, 14 Aug 2007 12:40:57 -0400
Message-ID: <46C1DB26.80200@redhat.com>
Date: Tue, 14 Aug 2007 16:41:00 -0000
From: Andrew Cagney <cagney@redhat.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20070530)
MIME-Version: 1.0
To: frysk@sourceware.org
Subject: adding print methods to frysk.value.Format
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact frysk-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <frysk.sourceware.org>
List-Subscribe: <mailto:frysk-subscribe@sourceware.org>
List-Post: <mailto:frysk@sourceware.org>
List-Help: <mailto:frysk-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: frysk-owner@sourceware.org
X-SW-Source: 2007-q3/txt/msg00294.txt.bz2

Just FYI,

I've gone through the code and removed a number of cases where 
frysk.value.Format was being treated as an enum, for instance:

    if (format == Format.HEXACECIMAL)
       print as hex
    else if (format == Format.DECIMAL)
       print as decimal
    ...

(and similarly for the Type's typeId).  This should instead be 
implemented by extending Format to handle the type in question, for 
instance:

    format.printPointer(PrintWriter, location-of-data)

While there were no test-suite regressions, I suspect, as the better 
implemented code is filled in, there may be some lurking untested 
user-visible regressions.

Andrew