From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16206 invoked by alias); 16 Aug 2007 17:30:54 -0000 Received: (qmail 16116 invoked by uid 22791); 16 Aug 2007 17:30:54 -0000 X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Aug 2007 17:30:46 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l7GHUg1x004158; Thu, 16 Aug 2007 13:30:42 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l7GHUfVX012400; Thu, 16 Aug 2007 13:30:41 -0400 Received: from toner.toronto.redhat.com (toner.toronto.redhat.com [172.16.14.55]) by pobox.toronto.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l7GHUf29015814; Thu, 16 Aug 2007 13:30:41 -0400 Message-ID: <46C489C1.40901@redhat.com> Date: Thu, 16 Aug 2007 17:30:00 -0000 From: Sami Wagiaalla User-Agent: Thunderbird 2.0.0.5 (X11/20070719) MIME-Version: 1.0 To: Mark Wielaard CC: frysk@sourceware.org, Nurdin Premji , Stan Cox Subject: Re: frysk-core/frysk gui/ChangeLog stack/RemoteFra ... References: <20070813221141.30722.qmail@sourceware.org> <1187168080.3804.23.camel@dijkstra.wildebeest.org> In-Reply-To: <1187168080.3804.23.camel@dijkstra.wildebeest.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00306.txt.bz2 Mark Wielaard wrote: > Hi, > > On Mon, 2007-08-13 at 22:11 +0000, npremji@sourceware.org wrote: > >> * RemoteFrame.java (getRegisterValue): Check for floating point registers. >> Don't throw a null pointer if register can't be located. >> > > This is the patch that broke a couple of tests on x86_64. Reverting it > makes the tests in frysk.debuginfo.TestFrameDebugInfo and > frysk.rt.TestUpdatingDisplayValue that throw NullPointerExceptions PASS > again. > I just committed a fix for this. The problem was that the code only checked for IntType and assumed all else is FloatType. A check for LongType was missing.