From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21964 invoked by alias); 22 Aug 2007 15:11:43 -0000 Received: (qmail 21929 invoked by uid 22791); 22 Aug 2007 15:11:42 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Aug 2007 15:11:38 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l7MFBalP027862 for ; Wed, 22 Aug 2007 11:11:36 -0400 Received: from pobox-2.corp.redhat.com (pobox-2.corp.redhat.com [10.11.255.15]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l7MFBaFW004334 for ; Wed, 22 Aug 2007 11:11:36 -0400 Received: from localhost.localdomain (vpn-14-253.rdu.redhat.com [10.11.14.253]) by pobox-2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l7MFBZFq009476 for ; Wed, 22 Aug 2007 11:11:35 -0400 Message-ID: <46CC5226.8040607@redhat.com> Date: Wed, 22 Aug 2007 15:11:00 -0000 From: Phil Muldoon User-Agent: Thunderbird 2.0.0.5 (X11/20070719) MIME-Version: 1.0 To: frysk@sourceware.org Subject: Re: frysk-core/frysk/proc Breakpoint.java IsaIA32. ... References: <20070115134847.31787.qmail@sourceware.org> In-Reply-To: <20070115134847.31787.qmail@sourceware.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00322.txt.bz2 mark@sourceware.org wrote: > CVSROOT: /cvs/frysk > Module name: frysk-core > Changes by: mark@sourceware.org 2007-01-15 13:48:47 > > Modified files: > frysk/proc : Breakpoint.java IsaIA32.java IsaX8664.java > LinuxIa32On64.java LinuxPtraceTaskState.java > TestTaskObserverInstruction.java > TestTaskObserverInstructionAndCode.java > > Log message: > Fixes bug #3676 > * Breakpoint.java (stepDone): Only set if still installed. > (isInstalled): new method. > (toString): Prettify. > * IsaIA32.java (isTaskStepped): Reset flag. > * IsaX8664.java (isTaskStepped): Likewise. > Mark, As we talked about on irc, and in addition to looking at this code in preparation for hardware watchpoints, can I make a small recommendation here? isTaskStepped(task) is a query, and should imo not be altering any debug registers after the fact. Can I propose a split into: isTaskStepped(task) and setTaskStepped(task) Does that make better sense? Regards Phil