From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29714 invoked by alias); 22 Aug 2007 21:33:18 -0000 Received: (qmail 29658 invoked by uid 22791); 22 Aug 2007 21:33:07 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Aug 2007 21:33:04 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l7MLX0hF027040; Wed, 22 Aug 2007 17:33:00 -0400 Received: from pobox-2.corp.redhat.com (pobox-2.corp.redhat.com [10.11.255.15]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l7MLX0oB007754; Wed, 22 Aug 2007 17:33:00 -0400 Received: from localhost.localdomain (vpn-14-253.rdu.redhat.com [10.11.14.253]) by pobox-2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l7MLWxsD016664; Wed, 22 Aug 2007 17:32:59 -0400 Message-ID: <46CCAB8B.5000202@redhat.com> Date: Wed, 22 Aug 2007 21:33:00 -0000 From: Phil Muldoon User-Agent: Thunderbird 2.0.0.5 (X11/20070719) MIME-Version: 1.0 To: Mark Wielaard CC: frysk@sourceware.org Subject: Re: Make CoredumpAction use Task.getRegisterBanks() References: <1185814384.3674.36.camel@dijkstra.wildebeest.org> <46AE238B.5020204@redhat.com> <1185883408.3653.106.camel@dijkstra.wildebeest.org> <46AFD351.6030004@redhat.com> <1186043315.15044.46.camel@dijkstra.wildebeest.org> In-Reply-To: <1186043315.15044.46.camel@dijkstra.wildebeest.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00326.txt.bz2 Mark Wielaard wrote: >> I think, going forward access to the raw memory for each register bank, >> and also a getRegisterByName() function (which is the functionality we >> have now) is needed, and probably will be down the line. >> > > If we can match up the raw memory for each register bank between > ptrace/proc and core files from Task that would be ideal. Then the Isa > can just do the getRegisterByName() mapping. I'll watch your rewrite of > the core file stuff and see if this makes things easier and clearer (I > guess it will). > > Now that all the register stuff is in, lets open this up again. In a corefile there are 3 sets of registers written for x86: General Purpose (GP) Registers Floating Point Registers (FP) eXtended Floating Point (XFP) Registers The first, GP Registers are written as part of a Elf prStatus note. One per thread. Because these registers are part of "another" struct, and do not have a note all to themselves, they have to be read one by one, sorted, then written into the structure along with other prStatus data (tid, and so on). Both FP and XFP both have their own note types and can be written wholesale as a bytebuffer to the corefile. No interpretation needed. Whether raw register memory access belongs in the ISA, the Task is not really important from a corefile view, though I would like to see it consistent. Regards Phil