From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16923 invoked by alias); 24 Aug 2007 12:54:49 -0000 Received: (qmail 16797 invoked by uid 22791); 24 Aug 2007 12:54:47 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Aug 2007 12:54:43 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l7OCsfBw005580 for ; Fri, 24 Aug 2007 08:54:41 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l7OCseAn008143 for ; Fri, 24 Aug 2007 08:54:40 -0400 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l7OCsdL9021503; Fri, 24 Aug 2007 08:54:40 -0400 Message-ID: <46CED526.402@redhat.com> Date: Fri, 24 Aug 2007 12:54:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Stan Cox CC: Frysk List Subject: Re: Value/Location References: <1187904534.968.63.camel@multics.rdu.redhat.com> In-Reply-To: <1187904534.968.63.camel@multics.rdu.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00340.txt.bz2 Yes, Every time I tried to get frysk.value.Format to use the type's byte-order I'd get test-suite failures caused by another case of this. The underling problem is that type code used to read/write byte-order dependent values wasn't explicitly specifying the type's required byte-order. Hopefully the last of these get flushed out with the next few commits. Andrew Stan Cox wrote: > The frysk.value constructor (Type type, String textFIXME) > ->calls (new Location(type.getSize()) > ->calls new ArrayByteBuffer(capacity) > which will assume a big endian buffer > > One possibility is to have Value do: > abb = new ArrayByteBuffer (..); > abb.order(type.endian); > Location(abb) > > > >