Re: Trouble with frysk.expunit.Expect and fhpd

[Adam Jocksch <ajocksch@redhat.com>]

Andrew Cagney wrote:
> Adam Jocksch wrote:
>> I've been trying to re-tool frysk.hpd.TestDisplayCommand to use 
>> funit-rt-varchange instead of hpd-c (bug #4951). However, the expect 
>> script fails when fhpd doesn't behave as expected when adding a 
>> breakpoint. I've attached the revised version of 
>> TestDisplayCommand.java as well as the log created by ./TestRunner 
>> -log frysk=FINE frysk.hpd.TestDisplayCommand. Running 
>> 'frysk/bindir/fhpd frysk/pkglibdir/funit-rt-varchange' from the 
>> frysk-core directory produces the expected results; it's only under 
>> Expect that fhpd is functioning strangely.
>>
> see: http://sourceware.org/bugzilla/show_bug.cgi?id=4914 and 4919 ; 
> missting synchronization in fhpd can lead to  expunit can feeding it 
> commands to fast.  Try adding a sleep(5) after the run, but before the 
> breakpoint is set; something like:
>
>        e.send("run " + Config.getPkgLibFile("funit-stepping-asm") + 
> "\n");
>        e.expect(5, "Attached.*\n" + prompt);
>
>        // Remove this - #4919 and #4914.
>        try { Thread.sleep(2000); } catch (Exception e) {}
>
>        e.send("break #" + source + "#" + startLine + "\n");
>        e.expect("breakpoint.*\n" + prompt);
>
> if this lets it work, keep the sleep and mark the test as 
> unresolved(4914).  We can then still run it with --unresolved.
>
Awesome, that worked like a charm. It also fixed the error with creating 
displays through expect. However in my testcase I don't send run to 
fhpd, rather I execute fhpd with the executable as an argument. For 
right now TestDisplayCommands is marked unresolved(4941) and passes and 
I have filed bz#4982 re: removing the sleep statements. If need be I can 
create a new bug for this race condition and change TestDisplayCommands 
appropriately.