From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <frysk-return-2336-listarch-frysk=sources.redhat.com@sourceware.org>
Received: (qmail 2598 invoked by alias); 30 Aug 2007 13:59:14 -0000
Received: (qmail 2583 invoked by uid 22791); 30 Aug 2007 13:59:13 -0000
X-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 30 Aug 2007 13:59:09 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l7UDwhiL006023; 	Thu, 30 Aug 2007 09:58:43 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l7UDwh02014894; 	Thu, 30 Aug 2007 09:58:43 -0400
Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) 	by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l7UDwgau001362; 	Thu, 30 Aug 2007 09:58:43 -0400
Message-ID: <46D6CD2F.9090409@redhat.com>
Date: Thu, 30 Aug 2007 13:59:00 -0000
From: Andrew Cagney <cagney@redhat.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20070530)
MIME-Version: 1.0
To: pearly.zhao@oracle.com
CC: Frysk Mailing List <frysk@sourceware.org>
Subject: Re: [patch] Fix bugs of memory window
References: <1188446167.7327.22.camel@linux-pzhao.site>
In-Reply-To: <1188446167.7327.22.camel@linux-pzhao.site>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact frysk-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <frysk.sourceware.org>
List-Subscribe: <mailto:frysk-subscribe@sourceware.org>
List-Post: <mailto:frysk@sourceware.org>
List-Help: <mailto:frysk-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: frysk-owner@sourceware.org
X-SW-Source: 2007-q3/txt/msg00371.txt.bz2

Zhao Shujing wrote:
> Hi,
>
> This patch is to fix bug #4617 and other bugs of memory window.
> - Fixed bug converting to bin and hex when memory value is negative
> number.
> - Fixed bug to get octal number by convert from hex.
> - Setting the font to fixed-width font "monospace 10"
> - Adding leading zero for all of bin, oct and hex.
> - Adding prefix zero to octal number.
>
> Any suggestions are welcomed
>
>   
Pearly, perhaps check the constructor <<new BigInteger(int,byte[])>> as 
in <<new BigInteger(1,b)>> it will convert the big-endian byte array 
directly into an unsigned BigInteger letting you use more of:

> +            oct = bihex.toString(8);
and, beyond needing to zero-pad, may make things even simpler.

Andrew