From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <frysk-return-2351-listarch-frysk=sources.redhat.com@sourceware.org>
Received: (qmail 11863 invoked by alias); 6 Sep 2007 13:54:12 -0000
Received: (qmail 11854 invoked by uid 22791); 6 Sep 2007 13:54:10 -0000
X-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 06 Sep 2007 13:54:04 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l86Ds1c2023135 	for <frysk@sourceware.org>; Thu, 6 Sep 2007 09:54:01 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l86Ds1PZ014536 	for <frysk@sourceware.org>; Thu, 6 Sep 2007 09:54:01 -0400
Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) 	by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l86Ds08R025914 	for <frysk@sourceware.org>; Thu, 6 Sep 2007 09:54:00 -0400
Message-ID: <46E0069C.2020104@redhat.com>
Date: Thu, 06 Sep 2007 13:54:00 -0000
From: Andrew Cagney <cagney@redhat.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20070530)
MIME-Version: 1.0
To: frysk@sourceware.org
Subject: Please, keep it private
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact frysk-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <frysk.sourceware.org>
List-Subscribe: <mailto:frysk-subscribe@sourceware.org>
List-Post: <mailto:frysk@sourceware.org>
List-Help: <mailto:frysk-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: frysk-owner@sourceware.org
X-SW-Source: 2007-q3/txt/msg00386.txt.bz2

Hi,

This change is interesting:

        * TestValue.java: Make all fields private.
        (longBEUnsignedType): Delete.
        (intBEUnsignedType): Delete.
        (shortBEUnsignedType): Delete.
        (byteBEUnsignedType): Delete.
        (floatBEType): Delete.
        (doubleBEType): Delete.
        (longUnsignedType): Delete.
        (intUnsignedType): Delete.
        (shortUnsignedType): Delete.
        (byteUnsignedType): Delete.

notice the consequence, of making those fields private.

When adding a field please start with the most private scope possible, 
even make it final.  Similarly, delay adding either a getEr or setEr 
method until it is clear that it is needed.

If we remember to do this, refactoring is relatively easy (dead 
variables are even identified by the compiler).  If we don't do this 
we're left with an accumulating pile of [likely] dead fields and 
methods.  something none of us want :-( :-)

Andrew