From: Andrew Cagney <cagney@redhat.com>
To: Kris Van Hees <kris.van.hees@oracle.com>
Cc: frysk@sourceware.org
Subject: Re: Patch for TearDownProcess
Date: Fri, 07 Sep 2007 13:31:00 -0000 [thread overview]
Message-ID: <46E15274.5020400@redhat.com> (raw)
In-Reply-To: <20070907022100.GK22263@oracle.com>
Kris Van Hees wrote:
> The attached patch *does* open the possibility that a stray process may remain
> after tearDown() has been executed if e.g. a process termination causes another
> process to be created, etc... However, that will not cause a testsuite hang.
> It is also not expected to pose a problem with the further execution of the
> testsuite (in fact, it is very likely to get cleaned up during the tearDown()
> of the next test).
>
Unfortunately this isn't theoretical. On a slower f5 machine; this
happens consistently; invalidating test results.
Given the choices between a potential test-suite hang, and tear-down
leaving waitpid events around, the decision was made in favor of the
latter. That decision hasn't changed. Having the test run hang, is a
lesser evil then the test-suite continuing but producing bogus results..
I restored the old behavior; and then added a timeout. It currently
logs a message, I suspect it should abandon the test run, since the
problem state hasn't gone away.
Andrew
next prev parent reply other threads:[~2007-09-07 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 2:22 Kris Van Hees
2007-09-07 13:31 ` Andrew Cagney [this message]
2007-09-07 14:30 ` Kris Van Hees
2007-09-07 18:39 ` Elena Zannoni
2007-09-13 12:34 ` Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E15274.5020400@redhat.com \
--to=cagney@redhat.com \
--cc=frysk@sourceware.org \
--cc=kris.van.hees@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).