From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28454 invoked by alias); 27 Sep 2007 14:53:13 -0000 Received: (qmail 28447 invoked by uid 22791); 27 Sep 2007 14:53:12 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,SPF_HELO_PASS,SPF_PASS,TW_FH X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 27 Sep 2007 14:53:10 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l8REr8fj016918 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 27 Sep 2007 10:53:08 -0400 Received: from pobox-2.corp.redhat.com (pobox-2.corp.redhat.com [10.11.255.15]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l8REr6Qx027773; Thu, 27 Sep 2007 10:53:06 -0400 Received: from localhost.localdomain (vpn-6-14.fab.redhat.com [10.33.6.14]) by pobox-2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l8REr4vi007207; Thu, 27 Sep 2007 10:53:05 -0400 Message-ID: <46FBC3D0.3060305@redhat.com> Date: Thu, 27 Sep 2007 14:53:00 -0000 From: Phil Muldoon User-Agent: Thunderbird 2.0.0.5 (X11/20070727) MIME-Version: 1.0 To: Andrew Cagney CC: Teresa Thomas , frysk Subject: Re: New fhpd commands: ptype & plocation References: <46FAC452.4010301@redhat.com> <46FB527F.2070809@redhat.com> <46FBC209.5050507@redhat.com> In-Reply-To: <46FBC209.5050507@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00408.txt.bz2 Andrew Cagney wrote: > Phil Muldoon wrote: >> Apart from the output code, and parsing code in fhpd, is the "get the >> location" code placed in a utility class somewhere? Can you give a >> programming example of given variable foo, how to get a location or >> locations in memory of where it resides? >> > Phil, > > I wouldn't become too attached to this command's implementation as it > currently stands; rather just view it as a a glimpse of what is to > come. That command reports the expression's result's location which > isn't sufficient; instead a walk of the expression tree that generates > a list of all referenced locations is going to be needed. > > I would define the frysk.proc. object interface that you require and > expect the location tree walk code to generate that that information; > rather than try to have frysk.proc directly access frysk.debuginfo. That's fair enough. From the observer point of view, all that is needed is a memory location and range - at the first pass. Later on as debug register usage is optimized to not map duplicate/overlapping ranges, it might be more meta-data. Still all of the above (Teresa's work) is neat stuff indeed. Happy to see it in the repo. Regards Phil