From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11783 invoked by alias); 15 Oct 2007 16:56:07 -0000 Received: (qmail 11771 invoked by uid 22791); 15 Oct 2007 16:56:06 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 15 Oct 2007 16:56:02 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id l9FGu0NS012894 for ; Mon, 15 Oct 2007 12:56:00 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l9FGu0Ot007197 for ; Mon, 15 Oct 2007 12:56:00 -0400 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l9FGtwES021292; Mon, 15 Oct 2007 12:55:59 -0400 Message-ID: <47139B3A.3000101@redhat.com> Date: Mon, 15 Oct 2007 16:56:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Stan Cox CC: Frysk List Subject: Re: generating type tests References: <1192223570.2947.145.camel@multics.rdu.redhat.com> In-Reply-To: <1192223570.2947.145.camel@multics.rdu.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00053.txt.bz2 Stan Cox wrote: > TypeEntry.java: > -Add getUnionType > -case DwTag.UNION_TYPE_ invoke getUnionType > -case DwTag.STRUCTURE_TYPE_ remove classType.setTypedefFIXME > -case DwTag.VOLATILE_TYPE_: new > -case DwTag.CONST_TYPE_: new > > ArrayType.java: > -Add public void toPrint(String s, PrintWriter writer) > This is to support the odd C syntax for pointer to array where the > pointer designation is embedded: int (* x) [2]. Using 1.5's > String.format would be nicer > > PointerType.java: > -Add public void toPrint(String s, PrintWriter writer) > Similar to above to handle pointer to array > > TypeDecorator.java > -special case PointerType so 'const int * x' and 'int * const x' are > handled properly > > CompositeType.java: > -Add public void toPrint(int indentation, PrintWriter writer) > -if member is a CompositeType invoke toPrint with indentation+2 > -special case pointer to array case > Can you post the patch? If you see an apparent need to add C specific "special cases" then there might have a problem with the code. Especially when frysk needs to be able to handle more than just C/C++. Time for the tree/visitor pattern? Andrew