From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18419 invoked by alias); 26 Oct 2007 15:53:16 -0000 Received: (qmail 18410 invoked by uid 22791); 26 Oct 2007 15:53:15 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 26 Oct 2007 15:53:12 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id l9QFr7SH007327; Fri, 26 Oct 2007 11:53:07 -0400 Received: from pobox.yyz.redhat.com (pobox.yyz.redhat.com [10.15.31.4]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l9QFr6bD012289; Fri, 26 Oct 2007 11:53:06 -0400 Received: from toner.toronto.redhat.com (toner.yyz.redhat.com [10.15.16.55]) by pobox.yyz.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l9QFr6BE015590; Fri, 26 Oct 2007 11:53:06 -0400 Message-ID: <47220D62.6020002@redhat.com> Date: Fri, 26 Oct 2007 15:53:00 -0000 From: Sami Wagiaalla User-Agent: Thunderbird 2.0.0.5 (X11/20070727) MIME-Version: 1.0 To: Mark Wielaard CC: frysk Subject: Re: Find right frame index in TestDebugInfoStackTrace.java References: <1193413323.2931.15.camel@hermans.wildebeest.org> In-Reply-To: <1193413323.2931.15.camel@hermans.wildebeest.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00080.txt.bz2 Thanks mark I so annoyed with this test :) Mark Wielaard wrote: > Hi, > > On a multi-core machine the TestDebugInfoStackTrace would sometimes fail > because the "signal_parent" task could still be in kernel, glibc signal > or kill helper functions. The following patch tries to find the right > index in that thread and uses that for the tests. > > 2007-10-26 Mark Wielaard > > * TestDebugInfoStackTrace.java (frameAssertions): Find and use > correct thread_parent task frame index. > > This makes this test reliably pass on my machine now even with different > frame index depths. But I found the test really hard to read so I > wouldn't mind someone double checking the fix. > > Cheers, > > Mark >